From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Lukasz Majewski <l.majewski@samsung.com>,
Andreas Faerber <afaerber@suse.de>,
Sachin Kamat <sachin.kamat@samsung.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3
Date: Wed, 2 Sep 2015 23:12:29 +0900 [thread overview]
Message-ID: <55E703CD.3060207@samsung.com> (raw)
In-Reply-To: <1433696621-4763-2-git-send-email-linux.amoon@gmail.com>
W dniu 08.06.2015 o 02:03, Anand Moon pisze:
> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3 board.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Dear Anand,
There was some confusion for this patch (mixed v3 and v2) so overall it
slipped through fingers.
Can you please:
1. Rebase and resend.
2. Enable them as built-ins, not modules. For exynos_defconfig
everything is built-in which makes easier to test on various boards.
3. Enable LEDS_GPIO. I don't know why it disappeared...
Best regards,
Krzysztof
> ---
> arch/arm/configs/exynos_defconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 1b7253b..2bbdf80 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_IDMAC=y
> CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=m
> +CONFIG_LEDS_PWM=m
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=m
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX77686=y
> CONFIG_RTC_DRV_MAX77802=y
>
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3
Date: Wed, 2 Sep 2015 23:12:29 +0900 [thread overview]
Message-ID: <55E703CD.3060207@samsung.com> (raw)
In-Reply-To: <1433696621-4763-2-git-send-email-linux.amoon@gmail.com>
W dniu 08.06.2015 o 02:03, Anand Moon pisze:
> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3 board.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Dear Anand,
There was some confusion for this patch (mixed v3 and v2) so overall it
slipped through fingers.
Can you please:
1. Rebase and resend.
2. Enable them as built-ins, not modules. For exynos_defconfig
everything is built-in which makes easier to test on various boards.
3. Enable LEDS_GPIO. I don't know why it disappeared...
Best regards,
Krzysztof
> ---
> arch/arm/configs/exynos_defconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 1b7253b..2bbdf80 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_IDMAC=y
> CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=m
> +CONFIG_LEDS_PWM=m
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=m
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX77686=y
> CONFIG_RTC_DRV_MAX77802=y
>
next prev parent reply other threads:[~2015-09-02 14:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 17:03 [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 Anand Moon
2015-06-07 17:03 ` Anand Moon
2015-06-07 17:03 ` [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM " Anand Moon
2015-06-07 17:03 ` Anand Moon
2015-06-08 15:11 ` Lukasz Majewski
2015-06-08 15:11 ` Lukasz Majewski
2015-06-08 23:56 ` Krzysztof Kozlowski
2015-06-08 23:56 ` Krzysztof Kozlowski
2015-06-09 3:08 ` Anand Moon
2015-06-09 3:08 ` Anand Moon
2015-09-02 14:12 ` Krzysztof Kozlowski [this message]
2015-09-02 14:12 ` Krzysztof Kozlowski
2015-09-02 15:40 ` Anand Moon
2015-09-02 15:40 ` Anand Moon
2015-06-08 15:10 ` [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 " Lukasz Majewski
2015-06-08 15:10 ` Lukasz Majewski
2015-06-08 23:50 ` Krzysztof Kozlowski
2015-06-08 23:50 ` Krzysztof Kozlowski
2015-06-09 2:39 ` Anand Moon
2015-06-09 2:39 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E703CD.3060207@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=afaerber@suse.de \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=sachin.kamat@samsung.com \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.