From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Anand Moon <moon.linux@yahoo.com>,
Andreas Faerber <afaerber@suse.de>,
Lukasz Majewski <l.majewski@samsung.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv5] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
Date: Thu, 03 Sep 2015 14:11:07 +0900 [thread overview]
Message-ID: <55E7D66B.4060401@samsung.com> (raw)
In-Reply-To: <1441252656-3034-1-git-send-email-linux.amoon@gmail.com>
On 03.09.2015 12:57, Anand Moon wrote:
> From: Anand Moon <moon.linux@yahoo.com>
>
> Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM,
> LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3/XU4 board.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> ---
> Changes from last version
> dropped following option.
> CONFIG_LEDS_CLASS_FLASH
> CONFIG_TRIGGER_ONESHOT
> CONFIG_TRIGGER_GPIO
Thank you. The patch looks good, commit message... almost. Now the
"From" address does not match "Signed-off-by".
Please fix and resubmit :) .
BR,
Krzysztof
> ---
> arch/arm/configs/exynos_defconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 9504e77..aaf7aa4 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_IDMAC=y
> CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> +CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_PWM=y
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=y
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX77686=y
> CONFIG_RTC_DRV_MAX77802=y
>
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
Date: Thu, 03 Sep 2015 14:11:07 +0900 [thread overview]
Message-ID: <55E7D66B.4060401@samsung.com> (raw)
In-Reply-To: <1441252656-3034-1-git-send-email-linux.amoon@gmail.com>
On 03.09.2015 12:57, Anand Moon wrote:
> From: Anand Moon <moon.linux@yahoo.com>
>
> Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM,
> LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3/XU4 board.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> ---
> Changes from last version
> dropped following option.
> CONFIG_LEDS_CLASS_FLASH
> CONFIG_TRIGGER_ONESHOT
> CONFIG_TRIGGER_GPIO
Thank you. The patch looks good, commit message... almost. Now the
"From" address does not match "Signed-off-by".
Please fix and resubmit :) .
BR,
Krzysztof
> ---
> arch/arm/configs/exynos_defconfig | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 9504e77..aaf7aa4 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_IDMAC=y
> CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> +CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_PWM=y
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=y
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX77686=y
> CONFIG_RTC_DRV_MAX77802=y
>
next prev parent reply other threads:[~2015-09-03 5:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 3:57 [PATCHv5] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4 Anand Moon
2015-09-03 3:57 ` Anand Moon
2015-09-03 5:11 ` Krzysztof Kozlowski [this message]
2015-09-03 5:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7D66B.4060401@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=afaerber@suse.de \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=moon.linux@yahoo.com \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.