From: Roger Quadros <rogerq@ti.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <dwmw2@infradead.org>, <ezequiel@vanguardiasur.com.ar>,
<tony@atomide.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH] mtd: nand: omap2: Rename shippable module to omap2_nand
Date: Thu, 3 Sep 2015 10:41:06 +0300 [thread overview]
Message-ID: <55E7F992.6050908@ti.com> (raw)
In-Reply-To: <20150902210637.GY81844@google.com>
On 03/09/15 00:06, Brian Norris wrote:
> On Fri, Aug 21, 2015 at 01:45:35PM +0300, Roger Quadros wrote:
>> As both omap2 onenand and omap2 nand driver modules are
>> named the same i.e. "omap2.ko", only one of them gets shipped
>> during MODPOST if both are configured as loadable modules.
>>
>> To avoid this ambiguity let's ship the omap2 nand
>> driver as "omap2_nand.ko"
>>
>> Reported by Pierre Neyron via github
>> https://github.com/beagleboard/linux/issues/40
>>
>> Cc: Robert Nelson <robertcnelson@gmail.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> drivers/mtd/nand/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
>> index 1f897ec..075a027 100644
>> --- a/drivers/mtd/nand/Makefile
>> +++ b/drivers/mtd/nand/Makefile
>> @@ -26,7 +26,8 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o
>> obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
>> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
>> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
>> -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
>> +omap2_nand-objs := omap2.o
>> +obj-$(CONFIG_MTD_NAND_OMAP2) += omap2_nand.o
>
> Pushed to l2-mtd.git. I suppose this one should go out for 4.3, as
> there's little downside to it, and it's kind of a bugfix.
That is perfectly fine. Thanks.
cheers,
-roger
>
>> obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
>> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
>> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
>> --
>> 2.1.4
>>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: dwmw2@infradead.org, ezequiel@vanguardiasur.com.ar,
tony@atomide.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH] mtd: nand: omap2: Rename shippable module to omap2_nand
Date: Thu, 3 Sep 2015 10:41:06 +0300 [thread overview]
Message-ID: <55E7F992.6050908@ti.com> (raw)
In-Reply-To: <20150902210637.GY81844@google.com>
On 03/09/15 00:06, Brian Norris wrote:
> On Fri, Aug 21, 2015 at 01:45:35PM +0300, Roger Quadros wrote:
>> As both omap2 onenand and omap2 nand driver modules are
>> named the same i.e. "omap2.ko", only one of them gets shipped
>> during MODPOST if both are configured as loadable modules.
>>
>> To avoid this ambiguity let's ship the omap2 nand
>> driver as "omap2_nand.ko"
>>
>> Reported by Pierre Neyron via github
>> https://github.com/beagleboard/linux/issues/40
>>
>> Cc: Robert Nelson <robertcnelson@gmail.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> drivers/mtd/nand/Makefile | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
>> index 1f897ec..075a027 100644
>> --- a/drivers/mtd/nand/Makefile
>> +++ b/drivers/mtd/nand/Makefile
>> @@ -26,7 +26,8 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o
>> obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
>> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
>> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
>> -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
>> +omap2_nand-objs := omap2.o
>> +obj-$(CONFIG_MTD_NAND_OMAP2) += omap2_nand.o
>
> Pushed to l2-mtd.git. I suppose this one should go out for 4.3, as
> there's little downside to it, and it's kind of a bugfix.
That is perfectly fine. Thanks.
cheers,
-roger
>
>> obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
>> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
>> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
>> --
>> 2.1.4
>>
next prev parent reply other threads:[~2015-09-03 7:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 10:45 [PATCH] mtd: nand: omap2: Rename shippable module to omap2_nand Roger Quadros
2015-08-21 10:45 ` Roger Quadros
2015-09-02 21:06 ` Brian Norris
2015-09-03 7:41 ` Roger Quadros [this message]
2015-09-03 7:41 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7F992.6050908@ti.com \
--to=rogerq@ti.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.