All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kasan: Don't use kasan shadow pointer in generic functions
Date: Thu, 3 Sep 2015 11:47:12 +0300	[thread overview]
Message-ID: <55E80910.20406@gmail.com> (raw)
In-Reply-To: <1441266863-5435-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On 09/03/2015 10:54 AM, Aneesh Kumar K.V wrote:
> We can't use generic functions like print_hex_dump to access kasan
> shadow region. This require us to setup another kasan shadow region
> for the address passed (kasan shadow address). Most architecture won't
> be able to do that.

s/Most architecture/Some architectures

At least ARM/ARM64/x86 are able to do that.


> Hence make a copy of the shadow region row and
> pass that to generic functions.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  mm/kasan/report.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Anyway, for this patch:
	Reviewed-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kasan: Don't use kasan shadow pointer in generic functions
Date: Thu, 3 Sep 2015 11:47:12 +0300	[thread overview]
Message-ID: <55E80910.20406@gmail.com> (raw)
In-Reply-To: <1441266863-5435-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On 09/03/2015 10:54 AM, Aneesh Kumar K.V wrote:
> We can't use generic functions like print_hex_dump to access kasan
> shadow region. This require us to setup another kasan shadow region
> for the address passed (kasan shadow address). Most architecture won't
> be able to do that.

s/Most architecture/Some architectures

At least ARM/ARM64/x86 are able to do that.


> Hence make a copy of the shadow region row and
> pass that to generic functions.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  mm/kasan/report.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Anyway, for this patch:
	Reviewed-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>

  reply	other threads:[~2015-09-03  8:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03  7:54 [PATCH 1/4] kasan: Rename kasan_enabled to kasan_report_enabled Aneesh Kumar K.V
2015-09-03  7:54 ` Aneesh Kumar K.V
2015-09-03  7:54 ` [PATCH 2/4] kasan: MODULE_VADDR is not available on all archs Aneesh Kumar K.V
2015-09-03  7:54   ` Aneesh Kumar K.V
2015-09-03  8:25   ` Andrey Ryabinin
2015-09-03  8:25     ` Andrey Ryabinin
2015-09-03  7:54 ` [PATCH 3/4] kasan: Don't use kasan shadow pointer in generic functions Aneesh Kumar K.V
2015-09-03  7:54   ` Aneesh Kumar K.V
2015-09-03  8:47   ` Andrey Ryabinin [this message]
2015-09-03  8:47     ` Andrey Ryabinin
2015-09-03  7:54 ` [PATCH 4/4] kasan: Prevent deadlock in kasan reporting Aneesh Kumar K.V
2015-09-03  7:54   ` Aneesh Kumar K.V
2015-09-03  9:15   ` Andrey Ryabinin
2015-09-03  9:15     ` Andrey Ryabinin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E80910.20406@gmail.com \
    --to=ryabinin.a.a@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.