Re: [patch] IB/core: missing curly braces in ib_find_gid()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Doug Ledford <dledford@redhat.com>
To: Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	Yotam Kenneth <yotamke-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] IB/core: missing curly braces in ib_find_gid()
Date: Thu, 03 Sep 2015 17:39:28 +0000	[thread overview]
Message-ID: <55E885D0.7070105@redhat.com> (raw)
In-Reply-To: <20150818092210.GE3965@mwanda>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On 08/18/2015 05:22 AM, Dan Carpenter wrote:
> Smatch says that, based on the indenting, we should probably add curly
> braces here.
> 
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 258b3f7..5d5bbae 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -807,9 +807,10 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
>  	for (port = rdma_start_port(device); port <= rdma_end_port(device); ++port) {
>  		if (rdma_cap_roce_gid_table(device, port)) {
>  			if (!ib_cache_gid_find_by_port(device, gid, port,
> -						       NULL, index))
> +						       NULL, index)) {
>  				*port_num = port;
>  				return 0;
> +			}
>  		}
>  
>  		for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {
> 


-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

WARNING: multiple messages have this Message-ID (diff)

From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Hal Rosenstock
	<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	Yotam Kenneth <yotamke-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] IB/core: missing curly braces in ib_find_gid()
Date: Thu, 3 Sep 2015 13:39:28 -0400	[thread overview]
Message-ID: <55E885D0.7070105@redhat.com> (raw)
In-Reply-To: <20150818092210.GE3965@mwanda>

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On 08/18/2015 05:22 AM, Dan Carpenter wrote:
> Smatch says that, based on the indenting, we should probably add curly
> braces here.
> 
> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Thanks, applied.

> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 258b3f7..5d5bbae 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -807,9 +807,10 @@ int ib_find_gid(struct ib_device *device, union ib_gid *gid,
>  	for (port = rdma_start_port(device); port <= rdma_end_port(device); ++port) {
>  		if (rdma_cap_roce_gid_table(device, port)) {
>  			if (!ib_cache_gid_find_by_port(device, gid, port,
> -						       NULL, index))
> +						       NULL, index)) {
>  				*port_num = port;
>  				return 0;
> +			}
>  		}
>  
>  		for (i = 0; i < device->port_immutable[port].gid_tbl_len; ++i) {
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

next prev parent reply	other threads:[~2015-09-03 17:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  9:22 [patch] IB/core: missing curly braces in ib_find_gid() Dan Carpenter
2015-08-18  9:22 ` Dan Carpenter
2015-08-29  1:10 ` ira.weiny
2015-08-29  1:10   ` ira.weiny
     [not found]   ` <20150829011040.GA2713-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-08-29  4:02     ` Doug Ledford
2015-08-29  4:02       ` Doug Ledford
2015-08-30  4:59       ` Or Gerlitz
2015-08-30  4:59         ` Or Gerlitz
2015-08-30 22:24         ` Doug Ledford
2015-08-30 22:24           ` Doug Ledford
2015-09-03 17:39 ` Doug Ledford [this message]
2015-09-03 17:39   ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E885D0.7070105@redhat.com \
    --to=dledford@redhat.com \
    --cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=yotamke-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.