From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Andreas Faerber <afaerber@suse.de>,
Lukasz Majewski <l.majewski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module
Date: Fri, 04 Sep 2015 15:42:50 +0900 [thread overview]
Message-ID: <55E93D6A.8030301@samsung.com> (raw)
In-Reply-To: <CANAwSgQwC3-Z364ZcGRbKCzQbNi_RYB_3cDRT0ZsxhhprW9mxQ@mail.gmail.com>
On 03.09.2015 14:20, Anand Moon wrote:
> Hi Krzysztof
>
> On 3 September 2015 at 10:32, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 03.09.2015 13:10, Anand Moon wrote:
>>> S3C2410_WATCHDOG watchdog drivers should not be loaded automatically,
>>> but only if a watchdog daemon is installed.
>>
>> First of all: why?
>>
>> Secondly: even as a module driver could be loaded automatically to match
>> enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it
>> does not hurt - watchdog should be inactive:
>>
>> s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq
>> disabled
>>
>> Best regards,
>> Krzysztof
>>
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>> arch/arm/configs/exynos_defconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>>> index aaf7aa4..b5d382e 100644
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
>>> CONFIG_THERMAL_EMULATION=y
>>> CONFIG_EXYNOS_THERMAL=y
>>> CONFIG_WATCHDOG=y
>>> -CONFIG_S3C2410_WATCHDOG=y
>>> +CONFIG_S3C2410_WATCHDOG=m
>>> CONFIG_MFD_CROS_EC=y
>>> CONFIG_MFD_CROS_EC_I2C=y
>>> CONFIG_MFD_CROS_EC_SPI=y
>>>
>
> All the watchdog drivers are blacklisted not to be loaded by the ubuntu.
> Their are some configurable parameters which get configured while
> loading of the module using watchdog daemon.
> Watchdog service will reconfigure watchdog driver while loading.
Thank you for clarification. First of all such information (that Ubuntu
requires it) should be put in commit message.
This looks like a requirement specific for Ubuntu. For example on Arch
these modules are not blacklisted. I don't know how this is handled on
Debian or Fedora.
Other defconfigs (including multi_v7) make these modules built-in.
Summarizing I am not convinced that the change is necessary. Having
everything built-in makes testing exynos defconfig easier because some
you just upload zImage and DTB to the testing board. With modules you
have to prepare the initramfs/initrd (e.g. for network boot).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module
Date: Fri, 04 Sep 2015 15:42:50 +0900 [thread overview]
Message-ID: <55E93D6A.8030301@samsung.com> (raw)
In-Reply-To: <CANAwSgQwC3-Z364ZcGRbKCzQbNi_RYB_3cDRT0ZsxhhprW9mxQ@mail.gmail.com>
On 03.09.2015 14:20, Anand Moon wrote:
> Hi Krzysztof
>
> On 3 September 2015 at 10:32, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 03.09.2015 13:10, Anand Moon wrote:
>>> S3C2410_WATCHDOG watchdog drivers should not be loaded automatically,
>>> but only if a watchdog daemon is installed.
>>
>> First of all: why?
>>
>> Secondly: even as a module driver could be loaded automatically to match
>> enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it
>> does not hurt - watchdog should be inactive:
>>
>> s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq
>> disabled
>>
>> Best regards,
>> Krzysztof
>>
>>>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>> arch/arm/configs/exynos_defconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>>> index aaf7aa4..b5d382e 100644
>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
>>> CONFIG_THERMAL_EMULATION=y
>>> CONFIG_EXYNOS_THERMAL=y
>>> CONFIG_WATCHDOG=y
>>> -CONFIG_S3C2410_WATCHDOG=y
>>> +CONFIG_S3C2410_WATCHDOG=m
>>> CONFIG_MFD_CROS_EC=y
>>> CONFIG_MFD_CROS_EC_I2C=y
>>> CONFIG_MFD_CROS_EC_SPI=y
>>>
>
> All the watchdog drivers are blacklisted not to be loaded by the ubuntu.
> Their are some configurable parameters which get configured while
> loading of the module using watchdog daemon.
> Watchdog service will reconfigure watchdog driver while loading.
Thank you for clarification. First of all such information (that Ubuntu
requires it) should be put in commit message.
This looks like a requirement specific for Ubuntu. For example on Arch
these modules are not blacklisted. I don't know how this is handled on
Debian or Fedora.
Other defconfigs (including multi_v7) make these modules built-in.
Summarizing I am not convinced that the change is necessary. Having
everything built-in makes testing exynos defconfig easier because some
you just upload zImage and DTB to the testing board. With modules you
have to prepare the initramfs/initrd (e.g. for network boot).
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-09-04 6:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 4:10 [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module Anand Moon
2015-09-03 4:10 ` Anand Moon
2015-09-03 5:02 ` Krzysztof Kozlowski
2015-09-03 5:02 ` Krzysztof Kozlowski
2015-09-03 5:20 ` Anand Moon
2015-09-03 5:20 ` Anand Moon
2015-09-04 6:42 ` Krzysztof Kozlowski [this message]
2015-09-04 6:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E93D6A.8030301@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=afaerber@suse.de \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.