All of lore.kernel.org
 help / color / mirror / Atom feed
From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH v7 1/5] lightnvm: Support for Open-Channel SSDs
Date: Fri, 04 Sep 2015 10:05:14 +0200	[thread overview]
Message-ID: <55E950BA.50203@bjorling.me> (raw)
In-Reply-To: <55E94301.3010501@cn.fujitsu.com>

>
> So here is a suggestion, register_bm again
> if we found nvm_dev->bm == NULL in create_target(). And if it is still
> NULL after that. return an error "nvm: no compatible bm was found"
> and stop target creating. Otherwise, there would be a NULL Pointer
> reference problem.
>
> That's a real problem I met in my testing and I did this change
> in my local using. I hope that's useful to you.
>
Hi Yang,

Similar to this?

diff --git i/drivers/lightnvm/core.c w/drivers/lightnvm/core.c
index 5e4c2b8..0d2e5e3 100644
--- i/drivers/lightnvm/core.c
+++ w/drivers/lightnvm/core.c
@@ -262,8 +262,9 @@ int nvm_init(struct nvm_dev *dev)
         }

         if (!ret) {
-               pr_info("nvm: no compatible bm was found.\n");
-               return 0;
+               pr_info("nvm: %s was not initialized due to no 
compatible bm.\n",
+                                                               dev->name);
+               return -EINVAL;
         }

         pr_info("nvm: registered %s with luns: %u blocks: %lu sector 
size: %d\n",

WARNING: multiple messages have this Message-ID (diff)
From: "Matias Bjørling" <m@bjorling.me>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
	hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: jg@lightnvm.io, Stephen.Bates@pmcs.com, keith.busch@intel.com,
	"Matias Bjørling" <mb@lightnvm.io>
Subject: Re: [PATCH v7 1/5] lightnvm: Support for Open-Channel SSDs
Date: Fri, 04 Sep 2015 10:05:14 +0200	[thread overview]
Message-ID: <55E950BA.50203@bjorling.me> (raw)
In-Reply-To: <55E94301.3010501@cn.fujitsu.com>

>
> So here is a suggestion, register_bm again
> if we found nvm_dev->bm == NULL in create_target(). And if it is still
> NULL after that. return an error "nvm: no compatible bm was found"
> and stop target creating. Otherwise, there would be a NULL Pointer
> reference problem.
>
> That's a real problem I met in my testing and I did this change
> in my local using. I hope that's useful to you.
>
Hi Yang,

Similar to this?

diff --git i/drivers/lightnvm/core.c w/drivers/lightnvm/core.c
index 5e4c2b8..0d2e5e3 100644
--- i/drivers/lightnvm/core.c
+++ w/drivers/lightnvm/core.c
@@ -262,8 +262,9 @@ int nvm_init(struct nvm_dev *dev)
         }

         if (!ret) {
-               pr_info("nvm: no compatible bm was found.\n");
-               return 0;
+               pr_info("nvm: %s was not initialized due to no 
compatible bm.\n",
+                                                               dev->name);
+               return -EINVAL;
         }

         pr_info("nvm: registered %s with luns: %u blocks: %lu sector 
size: %d\n",




  reply	other threads:[~2015-09-04  8:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 14:29 [PATCH v7 0/5] Support for Open-Channel SSDs Matias Bjørling
2015-08-07 14:29 ` Matias Bjørling
2015-08-07 14:29 ` [PATCH v7 1/5] lightnvm: " Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-09-02  3:50   ` Dongsheng Yang
2015-09-02  3:50     ` Dongsheng Yang
2015-09-02  3:50     ` Dongsheng Yang
2015-09-02 10:48     ` Matias Bjørling
2015-09-02 10:48       ` Matias Bjørling
2015-09-04  7:06       ` Dongsheng Yang
2015-09-04  7:06         ` Dongsheng Yang
2015-09-04  7:06         ` Dongsheng Yang
2015-09-04  8:05         ` Matias Bjørling [this message]
2015-09-04  8:05           ` Matias Bjørling
2015-09-04  8:27           ` Dongsheng Yang
2015-09-04  8:27             ` Dongsheng Yang
2015-09-04  8:49             ` Matias Bjørling
2015-09-04  8:49               ` Matias Bjørling
2015-08-07 14:29 ` [PATCH v7 2/5] lightnvm: Hybrid Open-Channel SSD RRPC target Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-08-07 14:29 ` [PATCH v7 3/5] lightnvm: Hybrid Open-Channel SSD block manager Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-08-07 14:29 ` [PATCH v7 4/5] null_nvm: Lightnvm test driver Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-08-07 14:29 ` [PATCH v7 5/5] nvme: LightNVM support Matias Bjørling
2015-08-07 14:29   ` Matias Bjørling
2015-09-02  3:50 ` [PATCH v7 0/5] Support for Open-Channel SSDs Dongsheng Yang
2015-09-02  3:50   ` Dongsheng Yang
2015-09-02  3:50   ` Dongsheng Yang
2015-09-02 10:59   ` Matias Bjørling
2015-09-02 10:59     ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E950BA.50203@bjorling.me \
    --to=m@bjorling.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.