* [Ocfs2-devel] [PATCH v2] ocfs2_direct_IO_write misses ocfs2_is_overwrite error code
@ 2015-09-07 6:32 Norton.Zhu
2015-09-07 7:10 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Norton.Zhu @ 2015-09-07 6:32 UTC (permalink / raw)
To: ocfs2-devel
If ocfs2_is_overwrite failed, ocfs2_direct_IO_write may still return success to the caller.
changelog:
Using mlog_errno(ret) looks better than mlog_errno(is_overwrite)
Signed-off-by: Norton.Zhu <norton.zhu@huawei.com>
---
aops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/aops.c b/aops.c
index 0f5fd9d..01bbc56 100644
--- a/aops.c
+++ b/aops.c
@@ -846,7 +846,8 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb,
is_overwrite = ocfs2_is_overwrite(osb, inode, offset);
if (is_overwrite < 0) {
- mlog_errno(is_overwrite);
+ ret = is_overwrite;
+ mlog_errno(ret);
ocfs2_inode_unlock(inode, 1);
goto clean_orphan;
}
--
1.8.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [PATCH v2] ocfs2_direct_IO_write misses ocfs2_is_overwrite error code
2015-09-07 6:32 [Ocfs2-devel] [PATCH v2] ocfs2_direct_IO_write misses ocfs2_is_overwrite error code Norton.Zhu
@ 2015-09-07 7:10 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2015-09-07 7:10 UTC (permalink / raw)
To: ocfs2-devel
On 2015/9/7 14:32, Norton.Zhu wrote:
> If ocfs2_is_overwrite failed, ocfs2_direct_IO_write may still return success to the caller.
> changelog:
> Using mlog_errno(ret) looks better than mlog_errno(is_overwrite)
>
> Signed-off-by: Norton.Zhu <norton.zhu@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
> ---
> aops.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/aops.c b/aops.c
> index 0f5fd9d..01bbc56 100644
> --- a/aops.c
> +++ b/aops.c
> @@ -846,7 +846,8 @@ static ssize_t ocfs2_direct_IO_write(struct kiocb *iocb,
>
> is_overwrite = ocfs2_is_overwrite(osb, inode, offset);
> if (is_overwrite < 0) {
> - mlog_errno(is_overwrite);
> + ret = is_overwrite;
> + mlog_errno(ret);
> ocfs2_inode_unlock(inode, 1);
> goto clean_orphan;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-07 6:32 [Ocfs2-devel] [PATCH v2] ocfs2_direct_IO_write misses ocfs2_is_overwrite error code Norton.Zhu
2015-09-07 7:10 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.