* [PATCH] leds: leds-hp6xx: Use devm_led_classdev_register
@ 2015-09-05 19:53 Muhammad Falak R Wani
2015-09-07 7:49 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-09-05 19:53 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, Jacek Anaszewski, linux-leds
Cc: linux-kernel, Muhammad Falak R Wani
Use resource-managed function devm_led_classdev_register
instead of led_classdev_register to simplify error path.
An unnecessary check of ret is replaced with a direct return
Also, remove redundant hp6xxled_remove.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/leds/leds-hp6xx.c | 17 ++---------------
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c
index 0b84c01..3b38ff0 100644
--- a/drivers/leds/leds-hp6xx.c
+++ b/drivers/leds/leds-hp6xx.c
@@ -59,28 +59,15 @@ static int hp6xxled_probe(struct platform_device *pdev)
{
int ret;
- ret = led_classdev_register(&pdev->dev, &hp6xx_red_led);
+ ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led);
if (ret < 0)
return ret;
- ret = led_classdev_register(&pdev->dev, &hp6xx_green_led);
- if (ret < 0)
- led_classdev_unregister(&hp6xx_red_led);
-
- return ret;
-}
-
-static int hp6xxled_remove(struct platform_device *pdev)
-{
- led_classdev_unregister(&hp6xx_red_led);
- led_classdev_unregister(&hp6xx_green_led);
-
- return 0;
+ return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led);
}
static struct platform_driver hp6xxled_driver = {
.probe = hp6xxled_probe,
- .remove = hp6xxled_remove,
.driver = {
.name = "hp6xx-led",
},
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: leds-hp6xx: Use devm_led_classdev_register
2015-09-05 19:53 [PATCH] leds: leds-hp6xx: Use devm_led_classdev_register Muhammad Falak R Wani
@ 2015-09-07 7:49 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-09-07 7:49 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Bryan Wu, Richard Purdie, linux-leds, linux-kernel
On 09/05/2015 09:53 PM, Muhammad Falak R Wani wrote:
> Use resource-managed function devm_led_classdev_register
> instead of led_classdev_register to simplify error path.
> An unnecessary check of ret is replaced with a direct return
> Also, remove redundant hp6xxled_remove.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/leds/leds-hp6xx.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
Merged, thanks.
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 7:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-05 19:53 [PATCH] leds: leds-hp6xx: Use devm_led_classdev_register Muhammad Falak R Wani
2015-09-07 7:49 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.