* [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
@ 2015-06-30 14:15 ` Dmitry Osipenko
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Osipenko @ 2015-06-30 14:15 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Alexandre Courbot, Marc Dietrich
Cc: Mika Westerberg, Rafael J. Wysocki, Dmitry Osipenko, stable,
linux-arm-kernel, linux-tegra, linux-kernel
Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
for ACPI") removed possibility to request GPIO by table index for non-ACPI
platforms without changing it users. As result "shutdown" GPIO request
will fail if request for "reset" GPIO succeeded or "reset" will be
requested instead of "shutdown" if "reset" wasn't defined. Fix it by
making gpiod_lookup_table use con_id's instead of indexes.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
Cc: <stable@vger.kernel.org> # v3.19+
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
arch/arm/mach-tegra/board-paz00.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
index fbe74c6..49d1110 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
static struct gpiod_lookup_table wifi_gpio_lookup = {
.dev_id = "rfkill_gpio",
.table = {
- GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
- GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
+ GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
+ GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
{ },
},
};
--
2.4.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
@ 2015-06-30 14:15 ` Dmitry Osipenko
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Osipenko @ 2015-06-30 14:15 UTC (permalink / raw)
To: linux-arm-kernel
Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
for ACPI") removed possibility to request GPIO by table index for non-ACPI
platforms without changing it users. As result "shutdown" GPIO request
will fail if request for "reset" GPIO succeeded or "reset" will be
requested instead of "shutdown" if "reset" wasn't defined. Fix it by
making gpiod_lookup_table use con_id's instead of indexes.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
Cc: <stable@vger.kernel.org> # v3.19+
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
---
v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
arch/arm/mach-tegra/board-paz00.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
index fbe74c6..49d1110 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
static struct gpiod_lookup_table wifi_gpio_lookup = {
.dev_id = "rfkill_gpio",
.table = {
- GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
- GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
+ GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
+ GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
{ },
},
};
--
2.4.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
2015-06-30 14:15 ` Dmitry Osipenko
@ 2015-06-30 20:44 ` Marc Dietrich
-1 siblings, 0 replies; 9+ messages in thread
From: Marc Dietrich @ 2015-06-30 20:44 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot,
Mika Westerberg, Rafael J. Wysocki, stable, linux-arm-kernel,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
Am Dienstag 30 Juni 2015, 17:15:50 schrieb Dmitry Osipenko:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> making gpiod_lookup_table use con_id's instead of indexes.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for
> ACPI) Cc: <stable@vger.kernel.org> # v3.19+
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
beside a small typo in the commit message (is users -> its users) this looks
good now. I can confirm that the gpio's are all available now.
Reviewed-by: Marc Dietrich <marvin24@gmx.de>
> ---
>
> v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be
> requested
>
> arch/arm/mach-tegra/board-paz00.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c
> b/arch/arm/mach-tegra/board-paz00.c index fbe74c6..49d1110 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> static struct gpiod_lookup_table wifi_gpio_lookup = {
> .dev_id = "rfkill_gpio",
> .table = {
> - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> { },
> },
> };
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
@ 2015-06-30 20:44 ` Marc Dietrich
0 siblings, 0 replies; 9+ messages in thread
From: Marc Dietrich @ 2015-06-30 20:44 UTC (permalink / raw)
To: linux-arm-kernel
Am Dienstag 30 Juni 2015, 17:15:50 schrieb Dmitry Osipenko:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> making gpiod_lookup_table use con_id's instead of indexes.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for
> ACPI) Cc: <stable@vger.kernel.org> # v3.19+
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
beside a small typo in the commit message (is users -> its users) this looks
good now. I can confirm that the gpio's are all available now.
Reviewed-by: Marc Dietrich <marvin24@gmx.de>
> ---
>
> v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be
> requested
>
> arch/arm/mach-tegra/board-paz00.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c
> b/arch/arm/mach-tegra/board-paz00.c index fbe74c6..49d1110 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> static struct gpiod_lookup_table wifi_gpio_lookup = {
> .dev_id = "rfkill_gpio",
> .table = {
> - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> { },
> },
> };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150630/47b9577a/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
2015-06-30 14:15 ` Dmitry Osipenko
@ 2015-09-07 9:21 ` Dmitry Osipenko
-1 siblings, 0 replies; 9+ messages in thread
From: Dmitry Osipenko @ 2015-09-07 9:21 UTC (permalink / raw)
To: Stephen Warren, Thierry Reding, Alexandre Courbot, Marc Dietrich
Cc: Mika Westerberg, Rafael J. Wysocki, stable, linux-arm-kernel,
linux-tegra, linux-kernel
30.06.2015 17:15, Dmitry Osipenko пишет:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> making gpiod_lookup_table use con_id's instead of indexes.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
> Cc: <stable@vger.kernel.org> # v3.19+
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>
> v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
>
> arch/arm/mach-tegra/board-paz00.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index fbe74c6..49d1110 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> static struct gpiod_lookup_table wifi_gpio_lookup = {
> .dev_id = "rfkill_gpio",
> .table = {
> - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> { },
> },
> };
>
Ping
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod_lookup table
@ 2015-09-07 9:21 ` Dmitry Osipenko
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Osipenko @ 2015-09-07 9:21 UTC (permalink / raw)
To: linux-arm-kernel
30.06.2015 17:15, Dmitry Osipenko ?????:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> making gpiod_lookup_table use con_id's instead of indexes.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
> Cc: <stable@vger.kernel.org> # v3.19+
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>
> v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
>
> arch/arm/mach-tegra/board-paz00.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index fbe74c6..49d1110 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> static struct gpiod_lookup_table wifi_gpio_lookup = {
> .dev_id = "rfkill_gpio",
> .table = {
> - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> { },
> },
> };
>
Ping
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's ingpiod_lookup table
2015-09-07 9:21 ` Dmitry Osipenko
@ 2015-09-08 7:59 ` Marc Dietrich
-1 siblings, 0 replies; 9+ messages in thread
From: Marc Dietrich @ 2015-09-08 7:59 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot,
Mika Westerberg, Rafael J. Wysocki, stable, linux-arm-kernel,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]
Am Montag, 7. September 2015, 12:21:37 schrieb Dmitry Osipenko:
> 30.06.2015 17:15, Dmitry Osipenko пишет:
> > Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> > for ACPI") removed possibility to request GPIO by table index for non-ACPI
> > platforms without changing it users. As result "shutdown" GPIO request
> > will fail if request for "reset" GPIO succeeded or "reset" will be
> > requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> > making gpiod_lookup_table use con_id's instead of indexes.
> >
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for
> > ACPI) Cc: <stable@vger.kernel.org> # v3.19+
> > Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> > ---
> >
> > v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be
> > requested>
> > arch/arm/mach-tegra/board-paz00.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-tegra/board-paz00.c
> > b/arch/arm/mach-tegra/board-paz00.c index fbe74c6..49d1110 100644
> > --- a/arch/arm/mach-tegra/board-paz00.c
> > +++ b/arch/arm/mach-tegra/board-paz00.c
> > @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> >
> > static struct gpiod_lookup_table wifi_gpio_lookup = {
> >
> > .dev_id = "rfkill_gpio",
> > .table = {
> >
> > - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> > - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> > + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> > + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> >
> > { },
> >
> > },
> >
> > };
>
> Ping
also
Tested-by: Marc Dietrich <marvin24@gmx.de>
I thing this should go through the tegra-soc tree. Thierry? Stephen?
Marc
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's ingpiod_lookup table
@ 2015-09-08 7:59 ` Marc Dietrich
0 siblings, 0 replies; 9+ messages in thread
From: Marc Dietrich @ 2015-09-08 7:59 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 7. September 2015, 12:21:37 schrieb Dmitry Osipenko:
> 30.06.2015 17:15, Dmitry Osipenko ?????:
> > Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> > for ACPI") removed possibility to request GPIO by table index for non-ACPI
> > platforms without changing it users. As result "shutdown" GPIO request
> > will fail if request for "reset" GPIO succeeded or "reset" will be
> > requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> > making gpiod_lookup_table use con_id's instead of indexes.
> >
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for
> > ACPI) Cc: <stable@vger.kernel.org> # v3.19+
> > Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> > ---
> >
> > v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be
> > requested>
> > arch/arm/mach-tegra/board-paz00.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-tegra/board-paz00.c
> > b/arch/arm/mach-tegra/board-paz00.c index fbe74c6..49d1110 100644
> > --- a/arch/arm/mach-tegra/board-paz00.c
> > +++ b/arch/arm/mach-tegra/board-paz00.c
> > @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
> >
> > static struct gpiod_lookup_table wifi_gpio_lookup = {
> >
> > .dev_id = "rfkill_gpio",
> > .table = {
> >
> > - GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> > - GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> > + GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> > + GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
> >
> > { },
> >
> > },
> >
> > };
>
> Ping
also
Tested-by: Marc Dietrich <marvin24@gmx.de>
I thing this should go through the tegra-soc tree. Thierry? Stephen?
Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150908/bb751e14/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread