From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Thierry Reding <treding@nvidia.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
Olof Johansson <olof@lixom.net>, Ray Jui <rjui@broadcom.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver
Date: Mon, 7 Sep 2015 11:30:03 +0200 [thread overview]
Message-ID: <55ED591B.4070600@osg.samsung.com> (raw)
In-Reply-To: <1441570566-14001-3-git-send-email-sjoerd.simons@collabora.co.uk>
Hello Sjoerd,
On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Active Semi act8846 is used as the PMIC on various Rockchip boards,
> enable the ACT8865 driver to support this.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 25a1d574..7058fef 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
> CONFIG_MFD_TPS6586X=y
> CONFIG_MFD_TPS65910=y
> CONFIG_REGULATOR_AB8500=y
> +CONFIG_REGULATOR_ACT8865=y
Same question than the previous patch, does this really need to be
built-in? The Kconfig symbol is tristate.
After an explanation why it needs to be built-in or enabling
it as a module:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver
Date: Mon, 7 Sep 2015 11:30:03 +0200 [thread overview]
Message-ID: <55ED591B.4070600@osg.samsung.com> (raw)
In-Reply-To: <1441570566-14001-3-git-send-email-sjoerd.simons@collabora.co.uk>
Hello Sjoerd,
On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Active Semi act8846 is used as the PMIC on various Rockchip boards,
> enable the ACT8865 driver to support this.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 25a1d574..7058fef 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
> CONFIG_MFD_TPS6586X=y
> CONFIG_MFD_TPS65910=y
> CONFIG_REGULATOR_AB8500=y
> +CONFIG_REGULATOR_ACT8865=y
Same question than the previous patch, does this really need to be
built-in? The Kconfig symbol is tristate.
After an explanation why it needs to be built-in or enabling
it as a module:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-09-07 9:30 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 20:16 [PATCH 0/4] ARM: multi_v7_defconfig: Improve rockchip support Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-06 20:16 ` [PATCH 3/4] ARM: multi_v7_defconfig: Enable Rockchip display support Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-07 9:31 ` Javier Martinez Canillas
2015-09-07 9:31 ` Javier Martinez Canillas
[not found] ` <1441570566-14001-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-06 20:16 ` [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-07 9:26 ` Javier Martinez Canillas
2015-09-07 9:26 ` Javier Martinez Canillas
2015-09-07 10:24 ` Sjoerd Simons
2015-09-07 10:24 ` Sjoerd Simons
2015-09-07 10:38 ` Javier Martinez Canillas
2015-09-07 10:38 ` Javier Martinez Canillas
2015-09-07 11:27 ` Thierry Reding
2015-09-07 11:27 ` Thierry Reding
2015-09-07 11:27 ` Thierry Reding
2015-09-07 10:55 ` Andy Yan
2015-09-07 10:55 ` Andy Yan
2015-09-07 11:06 ` Javier Martinez Canillas
2015-09-07 11:06 ` Javier Martinez Canillas
2015-09-06 20:16 ` [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-07 9:30 ` Javier Martinez Canillas [this message]
2015-09-07 9:30 ` Javier Martinez Canillas
[not found] ` <1441570566-14001-3-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-09-07 9:33 ` Heiko Stübner
2015-09-07 9:33 ` Heiko Stübner
2015-09-07 9:33 ` Heiko Stübner
2015-09-07 10:49 ` Andy Yan
2015-09-07 10:49 ` Andy Yan
2015-09-07 10:49 ` Andy Yan
2015-09-07 10:53 ` Heiko Stübner
2015-09-07 10:53 ` Heiko Stübner
2015-09-06 20:16 ` [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-06 20:16 ` Sjoerd Simons
2015-09-07 0:02 ` Krzysztof Kozlowski
2015-09-07 0:02 ` Krzysztof Kozlowski
2015-09-07 0:02 ` Krzysztof Kozlowski
2015-09-07 7:10 ` Sjoerd Simons
2015-09-07 7:10 ` Sjoerd Simons
2015-09-07 7:24 ` Krzysztof Kozlowski
2015-09-07 7:24 ` Krzysztof Kozlowski
[not found] ` <55ED3BC5.8050603-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-09-07 7:53 ` Heiko Stübner
2015-09-07 7:53 ` Heiko Stübner
2015-09-07 7:53 ` Heiko Stübner
2015-09-07 7:56 ` Krzysztof Kozlowski
2015-09-07 7:56 ` Krzysztof Kozlowski
2015-09-07 8:49 ` Sjoerd Simons
2015-09-07 8:49 ` Sjoerd Simons
2015-09-07 9:33 ` Javier Martinez Canillas
2015-09-07 9:33 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED591B.4070600@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=sjoerd.simons@collabora.co.uk \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.