From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, yhindin@redhat.com, leonid@daynix.com
Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies
Date: Mon, 7 Sep 2015 12:48:27 +0200 [thread overview]
Message-ID: <55ED6B7B.9060000@redhat.com> (raw)
In-Reply-To: <1440719744-24755-4-git-send-email-mdroth@linux.vnet.ibm.com>
On 28/08/2015 01:55, Michael Roth wrote:
> Now we can build qemu-ga MSI package with:
> ./configure ...
> make qemu-ga.exe
> make msi
>
> or simply:
> ./configure ...
> make msi
Shouldn't the latter have always worked?
I think that if someone does "make qemu-ga.exe" they should *not* get
the VSS files. Perhaps we can add a Win32-specific phony qemu-ga target
to build both qemu-ga.exe and the VSS files, but this patch's use of
filter-out is a bit ugly.
Paolo
next prev parent reply other threads:[~2015-09-07 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 23:55 [Qemu-devel] [PATCH v2 0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies Michael Roth
2015-09-07 10:48 ` Paolo Bonzini [this message]
2015-09-07 19:55 ` Michael Roth
2015-09-07 20:37 ` Michael Roth
2015-09-07 20:39 ` Paolo Bonzini
2015-09-07 20:51 ` Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message Michael Roth
-- strict thread matches above, loose matches on Subject: below --
2015-08-26 22:21 [Qemu-devel] [0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-26 22:21 ` [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies Michael Roth
2015-08-27 12:49 ` Marc-André Lureau
2015-08-27 13:46 ` Michael Roth
2015-08-27 14:00 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED6B7B.9060000@redhat.com \
--to=pbonzini@redhat.com \
--cc=leonid@daynix.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=yhindin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.