From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, yhindin@redhat.com, leonid@daynix.com
Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies
Date: Mon, 7 Sep 2015 22:39:39 +0200 [thread overview]
Message-ID: <55EDF60B.8000007@redhat.com> (raw)
In-Reply-To: <20150907203723.10296.29727@loki>
On 07/09/2015 22:37, Michael Roth wrote:
> This kinda does it, although it introduces a circular dependency warning
> on posix (since qemu-ga$(EXESUF) == qemu-ga there, yet qemu-ga has
> a qemu-ga$(EXESUF) dependency.
>
> Could be fixed by making a new 'qemu-guest-agent' do-the-right-thing target,
> but that means new build process for posix and w32 instead of just w32. The
> alternative is to only define the 'qemu-ga' do-the-right-thing target for w32
> (since posix already has such a target). That requires a Makefile ifdef MINGW
> or somesuch though, which isn't ideal. I think the latter is worth the
> simplified build process (same as we currently do on posix, but with some
> extra config params)
Or just "ifneq ($(EXESUF),)".
Paolo
next prev parent reply other threads:[~2015-09-07 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 23:55 [Qemu-devel] [PATCH v2 0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies Michael Roth
2015-09-07 10:48 ` Paolo Bonzini
2015-09-07 19:55 ` Michael Roth
2015-09-07 20:37 ` Michael Roth
2015-09-07 20:39 ` Paolo Bonzini [this message]
2015-09-07 20:51 ` Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message Michael Roth
-- strict thread matches above, loose matches on Subject: below --
2015-08-26 22:21 [Qemu-devel] [0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-26 22:21 ` [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies Michael Roth
2015-08-27 12:49 ` Marc-André Lureau
2015-08-27 13:46 ` Michael Roth
2015-08-27 14:00 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EDF60B.8000007@redhat.com \
--to=pbonzini@redhat.com \
--cc=leonid@daynix.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=yhindin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.