From: Mathias Nyman <mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller
Date: Tue, 08 Sep 2015 13:45:07 +0300 [thread overview]
Message-ID: <55EEBC33.5030906@intel.com> (raw)
In-Reply-To: <1441693083-8440-5-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Hi
On 08.09.2015 09:18, Chunfeng Yun wrote:
> There some vendor quirks for MTK xhci host controller:
> 1. It defines some extra SW scheduling parameters for HW
> to minimize the scheduling effort for synchronous and
> interrupt endpoints. The parameters are put into reseved
> DWs of slot context and endpoint context.
> 2. Its IMODI unit for Interrupter Moderation register is
> 8 times as much as that defined in xHCI spec.
> 3. Its TDS in Normal TRB defines a number of packets that
> remains to be transferred for a TD after processing all
> Max packets in all previous TRBs.
>
I just rewrote and unified the the xhci TD remainder functions,
now we got only one xhci_td_remainder() function which should
be more suitable for quirks.
You can add the quirk directly to it, no need to duplicate the
whole function.
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mathias.nyman@intel.com (Mathias Nyman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller
Date: Tue, 08 Sep 2015 13:45:07 +0300 [thread overview]
Message-ID: <55EEBC33.5030906@intel.com> (raw)
In-Reply-To: <1441693083-8440-5-git-send-email-chunfeng.yun@mediatek.com>
Hi
On 08.09.2015 09:18, Chunfeng Yun wrote:
> There some vendor quirks for MTK xhci host controller:
> 1. It defines some extra SW scheduling parameters for HW
> to minimize the scheduling effort for synchronous and
> interrupt endpoints. The parameters are put into reseved
> DWs of slot context and endpoint context.
> 2. Its IMODI unit for Interrupter Moderation register is
> 8 times as much as that defined in xHCI spec.
> 3. Its TDS in Normal TRB defines a number of packets that
> remains to be transferred for a TD after processing all
> Max packets in all previous TRBs.
>
I just rewrote and unified the the xhci TD remainder functions,
now we got only one xhci_td_remainder() function which should
be more suitable for quirks.
You can add the quirk directly to it, no need to duplicate the
whole function.
-Mathias
WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman@intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>,
linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org,
John Crispin <blogic@openwrt.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller
Date: Tue, 08 Sep 2015 13:45:07 +0300 [thread overview]
Message-ID: <55EEBC33.5030906@intel.com> (raw)
In-Reply-To: <1441693083-8440-5-git-send-email-chunfeng.yun@mediatek.com>
Hi
On 08.09.2015 09:18, Chunfeng Yun wrote:
> There some vendor quirks for MTK xhci host controller:
> 1. It defines some extra SW scheduling parameters for HW
> to minimize the scheduling effort for synchronous and
> interrupt endpoints. The parameters are put into reseved
> DWs of slot context and endpoint context.
> 2. Its IMODI unit for Interrupter Moderation register is
> 8 times as much as that defined in xHCI spec.
> 3. Its TDS in Normal TRB defines a number of packets that
> remains to be transferred for a TD after processing all
> Max packets in all previous TRBs.
>
I just rewrote and unified the the xhci TD remainder functions,
now we got only one xhci_td_remainder() function which should
be more suitable for quirks.
You can add the quirk directly to it, no need to duplicate the
whole function.
-Mathias
next prev parent reply other threads:[~2015-09-08 10:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:17 [PATCH v7 0/5] Mediatek xHCI support Chunfeng Yun
2015-09-08 6:17 ` Chunfeng Yun
2015-09-08 6:17 ` Chunfeng Yun
2015-09-08 6:17 ` [PATCH v7 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun
2015-09-08 6:17 ` Chunfeng Yun
2015-09-08 6:17 ` Chunfeng Yun
[not found] ` <1441693083-8440-2-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-09 0:16 ` Rob Herring
2015-09-09 0:16 ` Rob Herring
2015-09-09 0:16 ` Rob Herring
[not found] ` <55EF7A70.1080701-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-11 3:34 ` chunfeng yun
2015-09-11 3:34 ` chunfeng yun
2015-09-11 3:34 ` chunfeng yun
2015-09-09 13:58 ` Rob Herring
2015-09-09 13:58 ` Rob Herring
2015-09-09 13:58 ` Rob Herring
[not found] ` <1441693083-8440-1-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 6:18 ` [PATCH v7 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
[not found] ` <1441693083-8440-3-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-09 0:30 ` Rob Herring
2015-09-09 0:30 ` Rob Herring
2015-09-09 0:30 ` Rob Herring
[not found] ` <55EF7DB0.7040607-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-11 3:39 ` chunfeng yun
2015-09-11 3:39 ` chunfeng yun
2015-09-11 3:39 ` chunfeng yun
2015-09-08 6:18 ` [PATCH v7 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
2015-09-08 6:18 ` [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
[not found] ` <1441693083-8440-5-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 10:45 ` Mathias Nyman [this message]
2015-09-08 10:45 ` Mathias Nyman
2015-09-08 10:45 ` Mathias Nyman
[not found] ` <55EEBC33.5030906-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-08 11:09 ` [PATCH] xhci: create one unified function to calculate TRB TD remainder Mathias Nyman
2015-09-08 11:09 ` Mathias Nyman
[not found] ` <1441710591-4267-1-git-send-email-mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-08 11:46 ` Oliver Neukum
2015-09-08 11:46 ` Oliver Neukum
[not found] ` <1441712798.26994.41.camel-IBi9RG/b67k@public.gmane.org>
2015-09-08 12:21 ` Mathias Nyman
2015-09-08 12:21 ` Mathias Nyman
2015-09-11 4:08 ` chunfeng yun
2015-09-11 4:08 ` chunfeng yun
2015-10-06 13:48 ` Mathias Nyman
2015-09-11 4:30 ` chunfeng yun
2015-09-11 4:30 ` chunfeng yun
2015-09-11 9:54 ` chunfeng yun
2015-09-11 9:54 ` chunfeng yun
2015-09-08 6:18 ` [PATCH v7 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
2015-09-08 6:18 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEBC33.5030906@intel.com \
--to=mathias.nyman-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.