From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xenproject.org
Cc: Mark Rutland <mark.rutland@arm.com>,
wei.liu2@citrix.com, ian.campbell@citrix.com, JBeulich@suse.com
Subject: Re: [PATCH v2] efi: introduce efi_arch_flush_dcache_area
Date: Tue, 8 Sep 2015 12:21:01 +0100 [thread overview]
Message-ID: <55EEC49D.5070102@citrix.com> (raw)
In-Reply-To: <1441708697-578-1-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 08/09/15 11:38, Stefano Stabellini wrote:
> Objects loaded by FileHandle->Read need to be flushed from dcache,
> otherwise copy_from_paddr will read stale data when copying the kernel,
> causing a failure to boot.
It would have been nice to have some explanation why we can read stale
data in the commit message (see [1]).
It would avoid to look at the ML in the future to understand why this
patch is here.
> Introduce efi_arch_flush_dcache_area and call it from read_file.
>
> This commit introduces no functional changes on x86.
[1] http://www.gossamer-threads.com/lists/xen/devel/396892#396892
Regards,
--
Julien Grall
prev parent reply other threads:[~2015-09-08 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 10:38 [PATCH v2] efi: introduce efi_arch_flush_dcache_area Stefano Stabellini
2015-09-08 10:50 ` Ian Campbell
2015-09-08 11:21 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEC49D.5070102@citrix.com \
--to=julien.grall@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=mark.rutland@arm.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.