From: Eric Blake <eblake@redhat.com>
To: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Vincenzo Maffione <v.maffione@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Luigi Rizzo <rizzo@iet.unipi.it>
Subject: Re: [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init
Date: Wed, 9 Sep 2015 09:46:56 -0600 [thread overview]
Message-ID: <55F05470.4050201@redhat.com> (raw)
In-Reply-To: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.DirtY.iCE.hu@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On 09/07/2015 06:14 AM, Kővágó, Zoltán wrote:
> This way we no longer need NetClientOptions and can convert Netdev
> into a flat union.
>
> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
I may have reviewed this one, but I'm still not a fan of 3/7. Give me a
chance to post my introspection followup patches that cherry-pick pieces
of your work and make QMP netdev_add a full-fledged qapi-fied command;
I'll keep you on cc when I post.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-09 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 12:08 [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option Kővágó, Zoltán
2015-09-07 12:08 ` [Qemu-devel] [PATCH 1/7] qapi: support implicit structs in OptsVisitor Kővágó, Zoltán
2015-09-17 20:30 ` Eric Blake
2015-09-18 12:26 ` Eric Blake
2015-09-07 12:08 ` [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union Kővágó, Zoltán
2015-09-09 15:42 ` Eduardo Habkost
2015-09-07 12:08 ` [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct Kővágó, Zoltán
2015-09-15 14:54 ` Eric Blake
2015-09-07 12:14 ` [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init Kővágó, Zoltán
2015-09-09 15:46 ` Eric Blake [this message]
2015-09-07 12:14 ` [Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union Kővágó, Zoltán
2015-09-17 20:41 ` Eric Blake
2015-09-07 12:14 ` [Qemu-devel] [PATCH 6/7] qapi: reorder NetdevBase and Netdev Kővágó, Zoltán
2015-09-17 20:42 ` Eric Blake
2015-09-07 12:14 ` [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor Kővágó, Zoltán
2015-09-17 21:24 ` Eric Blake
2015-09-17 22:01 ` Kővágó Zoltán
2015-09-14 12:34 ` [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F05470.4050201@redhat.com \
--to=eblake@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=stefanha@redhat.com \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.