Re: [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

On 09/07/2015 06:08 AM, Kővágó, Zoltán wrote:
> NetLegacy is just Netdev with some extra fields (name, vlan) and an
> optional id.  This patch merges the two structs, and net_client_init1
> got some extra checks to make sure only accept valid -netdev command
> lines.  This is some extra work, but allows us to uniformly manage both
> legacy -net and non-legacy -netdev in code.
> 
> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
> ---
>  net/net.c        | 42 +++++++++++++++++++++---------------------
>  qapi-schema.json | 30 +++++++++---------------------
>  2 files changed, 30 insertions(+), 42 deletions(-)

I'm still not a fan of this one. See my counter-proposal that rewrites
patches 4/7 and 5/7 of this series to keep NetdevLegacy a separate type
for command line usage, while exposing only Netdev through QMP (in
particular, patch 2/29 and 27/29 are my rewrites, and 29/29 turns on
Netdev use in QMP)

https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02580.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]