From: Robert Baldyga <r.baldyga@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
gregkh@linuxfoundation.org
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label
Date: Thu, 10 Sep 2015 12:30:18 +0200 [thread overview]
Message-ID: <55F15BBA.7090609@samsung.com> (raw)
In-Reply-To: <55F0CE80.3030400@samsung.com>
On 09/10/2015 02:27 AM, Krzysztof Kozlowski wrote:
> On 08.09.2015 18:38, Robert Baldyga wrote:
>> This label does nothing special and we don't need to have it anymore.
>>
>> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
>> ---
>> drivers/tty/serial/samsung.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> Label does nothing but it has a meaning. It serves as a comment - ignore
> the character. So maybe:
>
> - goto ignore_char;
> + continue; /* Ignore character */
>
> What do you think?
Look good to me.
Thanks,
Robert
next prev parent reply other threads:[~2015-09-10 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 9:38 [PATCH 0/3] serial: samsung: Fix UART status handling and other fixes Robert Baldyga
2015-09-08 9:38 ` [PATCH 1/3] serial: samsung: remove unused 'irq' parameter Robert Baldyga
2015-09-10 0:25 ` Krzysztof Kozlowski
2015-09-08 9:38 ` [PATCH 2/3] serial: samsung: remove unneded 'ignore_char' label Robert Baldyga
2015-09-10 0:27 ` Krzysztof Kozlowski
2015-09-10 10:30 ` Robert Baldyga [this message]
2015-09-08 9:38 ` [PATCH 3/3] serial: samsung: Fix UART status handling in DMA mode Robert Baldyga
2015-09-10 0:47 ` Krzysztof Kozlowski
2015-09-10 10:41 ` Robert Baldyga
2015-09-08 23:47 ` [PATCH 0/3] serial: samsung: Fix UART status handling and other fixes Krzysztof Kozlowski
2015-09-09 9:15 ` Robert Baldyga
2015-09-10 0:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F15BBA.7090609@samsung.com \
--to=r.baldyga@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.