* [PATCH 0/1] of: to support binding numa node to specified device @ 2015-08-25 4:08 ` Zhen Lei 0 siblings, 0 replies; 7+ messages in thread From: Zhen Lei @ 2015-08-25 4:08 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei Changelog: v1 -> v2: In patch v1, binding numa node to specified device only take effect for dt-nodes directly of root. Patch v2 removed this limitation, we can binding numa node to any specified device in devicetree. Zhen Lei (1): of: to support binding numa node to specified device in devicetree drivers/base/core.c | 2 +- drivers/of/device.c | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/1] of: to support binding numa node to specified device @ 2015-08-25 4:08 ` Zhen Lei 0 siblings, 0 replies; 7+ messages in thread From: Zhen Lei @ 2015-08-25 4:08 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei Changelog: v1 -> v2: In patch v1, binding numa node to specified device only take effect for dt-nodes directly of root. Patch v2 removed this limitation, we can binding numa node to any specified device in devicetree. Zhen Lei (1): of: to support binding numa node to specified device in devicetree drivers/base/core.c | 2 +- drivers/of/device.c | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.5.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1440475702-7720-1-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]
* [PATCH 1/1] of: to support binding numa node to specified device in devicetree 2015-08-25 4:08 ` Zhen Lei @ 2015-08-25 4:08 ` Zhen Lei -1 siblings, 0 replies; 7+ messages in thread From: Zhen Lei @ 2015-08-25 4:08 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei For now, in function device_add, the new device will be forced to inherit the numa node of its parent. But this will override the device's numa node which configured in devicetree. Signed-off-by: Zhen Lei <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> --- drivers/base/core.c | 2 +- drivers/of/device.c | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index dafae6d..e06de82 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1017,7 +1017,7 @@ int device_add(struct device *dev) dev->kobj.parent = kobj; /* use parent numa_node */ - if (parent) + if (parent && (dev_to_node(dev) == NUMA_NO_NODE)) set_dev_node(dev, dev_to_node(parent)); /* first, register with generic layer. */ diff --git a/drivers/of/device.c b/drivers/of/device.c index 8b91ea2..e5f47ce 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -60,11 +60,12 @@ int of_device_add(struct platform_device *ofdev) ofdev->name = dev_name(&ofdev->dev); ofdev->id = -1; - /* device_add will assume that this device is on the same node as - * the parent. If there is no parent defined, set the node - * explicitly */ - if (!ofdev->dev.parent) - set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); + /* + * If this device has not binding numa node in devicetree, that is + * of_node_to_nid returns NUMA_NO_NODE. device_add will assume that this + * device is on the same node as the parent. + */ + set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); return device_add(&ofdev->dev); } -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/1] of: to support binding numa node to specified device in devicetree @ 2015-08-25 4:08 ` Zhen Lei 0 siblings, 0 replies; 7+ messages in thread From: Zhen Lei @ 2015-08-25 4:08 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo, Zhen Lei For now, in function device_add, the new device will be forced to inherit the numa node of its parent. But this will override the device's numa node which configured in devicetree. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/base/core.c | 2 +- drivers/of/device.c | 11 ++++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index dafae6d..e06de82 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1017,7 +1017,7 @@ int device_add(struct device *dev) dev->kobj.parent = kobj; /* use parent numa_node */ - if (parent) + if (parent && (dev_to_node(dev) == NUMA_NO_NODE)) set_dev_node(dev, dev_to_node(parent)); /* first, register with generic layer. */ diff --git a/drivers/of/device.c b/drivers/of/device.c index 8b91ea2..e5f47ce 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -60,11 +60,12 @@ int of_device_add(struct platform_device *ofdev) ofdev->name = dev_name(&ofdev->dev); ofdev->id = -1; - /* device_add will assume that this device is on the same node as - * the parent. If there is no parent defined, set the node - * explicitly */ - if (!ofdev->dev.parent) - set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); + /* + * If this device has not binding numa node in devicetree, that is + * of_node_to_nid returns NUMA_NO_NODE. device_add will assume that this + * device is on the same node as the parent. + */ + set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); return device_add(&ofdev->dev); } -- 2.5.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1440475702-7720-2-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH v2 1/1] of: to support binding numa node to specified device in devicetree 2015-08-25 4:08 ` Zhen Lei @ 2015-09-10 11:28 ` Leizhen (ThunderTown) -1 siblings, 0 replies; 7+ messages in thread From: Leizhen (ThunderTown) @ 2015-09-10 11:28 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo Hi all, Can somebody take a few moments to review it? This patch is too small, only changed two lines. Thanks, Thunder. On 2015/8/25 12:08, Zhen Lei wrote: > For now, in function device_add, the new device will be forced to > inherit the numa node of its parent. But this will override the device's > numa node which configured in devicetree. > > Signed-off-by: Zhen Lei <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> > --- > drivers/base/core.c | 2 +- > drivers/of/device.c | 11 ++++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index dafae6d..e06de82 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1017,7 +1017,7 @@ int device_add(struct device *dev) > dev->kobj.parent = kobj; > > /* use parent numa_node */ > - if (parent) > + if (parent && (dev_to_node(dev) == NUMA_NO_NODE)) > set_dev_node(dev, dev_to_node(parent)); > > /* first, register with generic layer. */ > diff --git a/drivers/of/device.c b/drivers/of/device.c > index 8b91ea2..e5f47ce 100644 > --- a/drivers/of/device.c > +++ b/drivers/of/device.c > @@ -60,11 +60,12 @@ int of_device_add(struct platform_device *ofdev) > ofdev->name = dev_name(&ofdev->dev); > ofdev->id = -1; > > - /* device_add will assume that this device is on the same node as > - * the parent. If there is no parent defined, set the node > - * explicitly */ > - if (!ofdev->dev.parent) > - set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); > + /* > + * If this device has not binding numa node in devicetree, that is > + * of_node_to_nid returns NUMA_NO_NODE. device_add will assume that this > + * device is on the same node as the parent. > + */ > + set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); > > return device_add(&ofdev->dev); > } > -- > 2.5.0 > > > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/1] of: to support binding numa node to specified device in devicetree @ 2015-09-10 11:28 ` Leizhen (ThunderTown) 0 siblings, 0 replies; 7+ messages in thread From: Leizhen (ThunderTown) @ 2015-09-10 11:28 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo Hi all, Can somebody take a few moments to review it? This patch is too small, only changed two lines. Thanks, Thunder. On 2015/8/25 12:08, Zhen Lei wrote: > For now, in function device_add, the new device will be forced to > inherit the numa node of its parent. But this will override the device's > numa node which configured in devicetree. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/base/core.c | 2 +- > drivers/of/device.c | 11 ++++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index dafae6d..e06de82 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1017,7 +1017,7 @@ int device_add(struct device *dev) > dev->kobj.parent = kobj; > > /* use parent numa_node */ > - if (parent) > + if (parent && (dev_to_node(dev) == NUMA_NO_NODE)) > set_dev_node(dev, dev_to_node(parent)); > > /* first, register with generic layer. */ > diff --git a/drivers/of/device.c b/drivers/of/device.c > index 8b91ea2..e5f47ce 100644 > --- a/drivers/of/device.c > +++ b/drivers/of/device.c > @@ -60,11 +60,12 @@ int of_device_add(struct platform_device *ofdev) > ofdev->name = dev_name(&ofdev->dev); > ofdev->id = -1; > > - /* device_add will assume that this device is on the same node as > - * the parent. If there is no parent defined, set the node > - * explicitly */ > - if (!ofdev->dev.parent) > - set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); > + /* > + * If this device has not binding numa node in devicetree, that is > + * of_node_to_nid returns NUMA_NO_NODE. device_add will assume that this > + * device is on the same node as the parent. > + */ > + set_dev_node(&ofdev->dev, of_node_to_nid(ofdev->dev.of_node)); > > return device_add(&ofdev->dev); > } > -- > 2.5.0 > > > > . > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/1] of: to support binding numa node to specified device 2015-08-25 4:08 ` Zhen Lei (?) (?) @ 2015-09-10 11:06 ` Leizhen (ThunderTown) -1 siblings, 0 replies; 7+ messages in thread From: Leizhen (ThunderTown) @ 2015-09-10 11:06 UTC (permalink / raw) To: Grant Likely, Rob Herring, devicetree, Greg Kroah-Hartman, linux-kernel Cc: Zefan Li, Xinwei Hu, Tianhong Ding, Hanjun Guo Sorry, missed version number in title. On 2015/8/25 12:08, Zhen Lei wrote: > Changelog: > v1 -> v2: > In patch v1, binding numa node to specified device only take effect for dt-nodes > directly of root. Patch v2 removed this limitation, we can binding numa node to > any specified device in devicetree. > > Zhen Lei (1): > of: to support binding numa node to specified device in devicetree > > drivers/base/core.c | 2 +- > drivers/of/device.c | 11 ++++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-10 11:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25 4:08 [PATCH 0/1] of: to support binding numa node to specified device Zhen Lei
2015-08-25 4:08 ` Zhen Lei
[not found] ` <1440475702-7720-1-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-08-25 4:08 ` [PATCH 1/1] of: to support binding numa node to specified device in devicetree Zhen Lei
2015-08-25 4:08 ` Zhen Lei
[not found] ` <1440475702-7720-2-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-09-10 11:28 ` [PATCH v2 " Leizhen (ThunderTown)
2015-09-10 11:28 ` Leizhen (ThunderTown)
2015-09-10 11:06 ` [PATCH v2 0/1] of: to support binding numa node to specified device Leizhen (ThunderTown)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.