Re: [Devel] PATCH proposal removing use of strtoul in events/evgpeinit.c

[Richard PALO <richard at netbsd.org>]

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

Le 11/09/15 16:57, Moore, Robert a écrit :
> Not to mention that every compiler is different, and you need to put your own "ignore error" types of things in your platform-specific or compiler-specific header. Such is the price of attempting to build OS- and compiler-independent code.
> 

>>> not to mention kludge needed when linting global crosschecks in the
>>> illumos gate, for the later
>>>> "/home/richard/src/illumos-gate/usr/src/common/acpica/components/dis
>>>> pa tcher/dsobject.c", line 351: warning: function returns value
>>>> which is sometimes ignored: memcpy (E_FUNC_RET_MAYBE_IGNORED2)
>>>> "/home/richard/src/illumos-gate/usr/src/common/acpica/components/dis
>>>> pa tcher/dsutils.c", line 608: warning: function returns value which
>>>> is sometimes ignored: strncpy (E_FUNC_RET_MAYBE_IGNORED2)
>>>> "/home/richard/src/illumos-gate/usr/src/common/acpica/components/exe
>>>> cu ter/exmisc.c", line 370: warning: function returns value which is
>>>> sometimes ignored: strcpy (E_FUNC_RET_MAYBE_IGNORED2)
>>>> "/home/richard/src/illumos-gate/usr/src/common/acpica/components/exe
>>>> cu ter/exnames.c", line 224: warning: function returns value which
>>>> is sometimes ignored: strcat (E_FUNC_RET_MAYBE_IGNORED2)
>>>

? Sorry, I guess I don't follow. for example, posix, and various c standards define memcpy as 
>  void *memcpy(void *restrict s1, const void *restrict s2, size_t n);

the first reference above, components/dispatcher/dsobject.c does:

> 349         if (ByteList)
> 350         {
> 351             memcpy (ObjDesc->Buffer.Pointer, ByteList->Named.Data,
> 352                          ByteListLength);
> 353         }

what would make most static analyzers happy is a simple void cast -- (void) memcpy(...)

Then, at least, ignoring the return value is explicit instead of possibly 
just being forgotten.. 

This should also be the most portable form of C (at least for the cases at hand).

There are numerous examples of this sort of thing over and above what I listed above...

cheers,
-- 
Richard PALO