Re: [prelink-cross] LD_PRELOAD Implementation in Prelink

Re: [prelink-cross] LD_PRELOAD Implementation in Prelink

[Maninder Singh]

Hi Mark,

Thanks for checking,

There is one bug in this patch , we will share the fix after testing probably on monday.

Thanks
Maninder Singh


>>Merged to the staging branch.

>On 5/18/15 12:17 AM, Maninder Singh wrote:
>> EP-F6AA0618C49C4AEDA73BFF1B39950BAB
>> Hi,
>> 
>> Subject: [PATCH 1/1] LD_PRELOAD Implementation in Prelink
>> 
>> prelink fails if  there are ld_preload libs present at target with below error.
>> 	expect libsX.so.1, found /lib/libY.so in dependency order
>> 	where libY.so.1 is ld_preload lib
>>  
>> To use this feature :
>> ./prelink --ld-preload=libpreload1.so:libpreload2.so:.... upto 20 libs
>> Order of libraries to be preloaded is significant. Make sure sequence
>> mentioned in prelink
>> should be same as runtime sequence.
>> 
>> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
>> Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
>> ---
>>  src/gather.c    |    8 +++++++-
>>  src/get.c       |    9 ++++++++-
>>  src/main.c      |    6 ++++++
>>  src/prelink.h   |    1 +
>>  src/rtld/rtld.c |   51 +++++++++++++++++++++++++++++++++++++++++++++------
>>  5 files changed, 67 insertions(+), 8 deletions(-)

Re: [prelink-cross] LD_PRELOAD Implementation in Prelink

[Mark Hatle]

On 9/12/15 12:35 AM, Maninder Singh wrote:
> Hi Mark,
> 
> Thanks for checking,
> 
> There is one bug in this patch , we will share the fix after testing probably on monday.

I added what I thought was a fairly reasonable test case to prelink.
testsuite/preload1*

Can you update the test case to include a specific check for the failure you are
aware of so we can avoid it in the future?

--Mark

> Thanks
> Maninder Singh
> 
> 
>>> Merged to the staging branch.
> 
>> On 5/18/15 12:17 AM, Maninder Singh wrote:
>>> EP-F6AA0618C49C4AEDA73BFF1B39950BAB
>>> Hi,
>>>
>>> Subject: [PATCH 1/1] LD_PRELOAD Implementation in Prelink
>>>
>>> prelink fails if  there are ld_preload libs present at target with below error.
>>> 	expect libsX.so.1, found /lib/libY.so in dependency order
>>> 	where libY.so.1 is ld_preload lib
>>>  
>>> To use this feature :
>>> ./prelink --ld-preload=libpreload1.so:libpreload2.so:.... upto 20 libs
>>> Order of libraries to be preloaded is significant. Make sure sequence
>>> mentioned in prelink
>>> should be same as runtime sequence.
>>>
>>> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
>>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>>> Reviewed-by: Ajeet Yadav <ajeet.v@samsung.com>
>>> Reviewed-by: Geon-ho Kim <gh007.kim@samsung.com>
>>> ---
>>>  src/gather.c    |    8 +++++++-
>>>  src/get.c       |    9 ++++++++-
>>>  src/main.c      |    6 ++++++
>>>  src/prelink.h   |    1 +
>>>  src/rtld/rtld.c |   51 +++++++++++++++++++++++++++++++++++++++++++++------
>>>  5 files changed, 67 insertions(+), 8 deletions(-)