From: chenfeng <puck.chen@hisilicon.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, xuwei5@hisilicon.com,
haojian.zhuang@linaro.org, zhangfei.gao@foxmail.com,
xuyiping@hisilicon.com, bintian.wang@huawei.com,
devicetree@vger.kernel.org, dan.zhao@hisilicon.com,
suzhuangluan@hisilicon.com, w.f@huawei.com
Subject: Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC
Date: Mon, 14 Sep 2015 10:02:00 +0800 [thread overview]
Message-ID: <55F62A98.7000205@hisilicon.com> (raw)
In-Reply-To: <2464506.5Jp1Wg3qfc@wuerfel>
On 2015/9/11 16:41, Arnd Bergmann wrote:
> On Friday 11 September 2015 16:18:38 Chen Feng wrote:
>> +static int __init hi6220_reset_init(void)
>> +{
>> + int ret;
>> + struct device_node *np;
>> + struct hi6220_reset_data *data;
>> +
>> + data = kzalloc(sizeof(*data), GFP_KERNEL);
>> + if (!data)
>> + return -ENOMEM;
>> +
>> + np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl");
>> + if (!np) {
>> + ret = -ENXIO;
>> + goto err_alloc;
>> + }
>
> Why is this not a platform driver?
>
OK,I will change this to a platform driver.
>> + if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
>> + reset_controller_register(&data->rc_dev);
>> +
>> + return 0;
>
> The Kconfig symbol already depends on RESET_CONTROLLER, so
> the IS_ENABLED() check looks redundant.
>
Yes,agree with you.
> Arnd
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: chenfeng <puck.chen@hisilicon.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <p.zabel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@foxmail.com>, <xuyiping@hisilicon.com>,
<bintian.wang@huawei.com>, <devicetree@vger.kernel.org>,
<dan.zhao@hisilicon.com>, <suzhuangluan@hisilicon.com>,
<w.f@huawei.com>
Subject: Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC
Date: Mon, 14 Sep 2015 10:02:00 +0800 [thread overview]
Message-ID: <55F62A98.7000205@hisilicon.com> (raw)
In-Reply-To: <2464506.5Jp1Wg3qfc@wuerfel>
On 2015/9/11 16:41, Arnd Bergmann wrote:
> On Friday 11 September 2015 16:18:38 Chen Feng wrote:
>> +static int __init hi6220_reset_init(void)
>> +{
>> + int ret;
>> + struct device_node *np;
>> + struct hi6220_reset_data *data;
>> +
>> + data = kzalloc(sizeof(*data), GFP_KERNEL);
>> + if (!data)
>> + return -ENOMEM;
>> +
>> + np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl");
>> + if (!np) {
>> + ret = -ENXIO;
>> + goto err_alloc;
>> + }
>
> Why is this not a platform driver?
>
OK,I will change this to a platform driver.
>> + if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
>> + reset_controller_register(&data->rc_dev);
>> +
>> + return 0;
>
> The Kconfig symbol already depends on RESET_CONTROLLER, so
> the IS_ENABLED() check looks redundant.
>
Yes,agree with you.
> Arnd
>
> .
>
next prev parent reply other threads:[~2015-09-14 2:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 8:18 [PATCH V2 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC Chen Feng
2015-09-11 8:18 ` Chen Feng
2015-09-11 8:18 ` [PATCH V2 2/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings Chen Feng
2015-09-11 8:18 ` Chen Feng
[not found] ` <1441959518-178696-1-git-send-email-puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-09-11 8:18 ` [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC Chen Feng
2015-09-11 8:18 ` Chen Feng
2015-09-11 8:41 ` Arnd Bergmann
2015-09-14 2:02 ` chenfeng [this message]
2015-09-14 2:02 ` chenfeng
2015-09-12 6:06 ` xuyiping
2015-09-12 6:06 ` xuyiping
[not found] ` <55F3C0DB.5070800-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-09-14 2:02 ` chenfeng
2015-09-14 2:02 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F62A98.7000205@hisilicon.com \
--to=puck.chen@hisilicon.com \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=zhangfei.gao@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.