Re: [PATCH 2/3] reiser4: fix reiser4_init_csum_tfm() error path; return real (negative) error code.

[Edward Shishkin <edward.shishkin@gmail.com>]

OK.
Thanks!

On 09/14/2015 01:08 AM, Ivan Shapovalov wrote:
> Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
> ---
>
> This is responsible for the oops on mount reported by Jose (also experienced
> by me). The problem is that IS_ERR() works only for negative error codes,
> so somewhere in the VFS an error path is incorrectly not taken.
>
>   fs/reiser4/checksum.c | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/fs/reiser4/checksum.c b/fs/reiser4/checksum.c
> index a5052b0..73d40f0 100644
> --- a/fs/reiser4/checksum.c
> +++ b/fs/reiser4/checksum.c
> @@ -4,11 +4,13 @@
>   
>   int reiser4_init_csum_tfm(struct crypto_shash **tfm)
>   {
> -	*tfm = crypto_alloc_shash("crc32c", 0, 0);
> -	if (IS_ERR(*tfm)) {
> -		*tfm = NULL;
> -		return 1;
> -	}
> +	struct crypto_shash *new_tfm;
> +
> +	new_tfm = crypto_alloc_shash("crc32c", 0, 0);
> +	if (IS_ERR(new_tfm))
> +		return PTR_ERR(new_tfm);
> +
> +	*tfm = new_tfm;
>   	return 0;
>   }
>