Re: [PATCH 3/3] reiser4: report an error on checksum engine load failure.

[Edward Shishkin <edward.shishkin@gmail.com>]

OK

On 09/14/2015 01:08 AM, Ivan Shapovalov wrote:
> It is apparently not possible to specify explicit module dependencies.
> For well-formed setups this is not a problem because
> crypto_alloc_shash() uses request_module() internally, but if one needs
> reiser4, say, in initramfs, then the checksum module must be added
> manually.
>
> Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
> ---
>   fs/reiser4/checksum.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/reiser4/checksum.c b/fs/reiser4/checksum.c
> index 73d40f0..2a35f42 100644
> --- a/fs/reiser4/checksum.c
> +++ b/fs/reiser4/checksum.c
> @@ -7,8 +7,10 @@ int reiser4_init_csum_tfm(struct crypto_shash **tfm)
>   	struct crypto_shash *new_tfm;
>   
>   	new_tfm = crypto_alloc_shash("crc32c", 0, 0);
> -	if (IS_ERR(new_tfm))
> +	if (IS_ERR(new_tfm)) {
> +		warning("intelfx-81", "Could not load crc32c driver");
>   		return PTR_ERR(new_tfm);
> +	}
>   
>   	*tfm = new_tfm;
>   	return 0;