Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

On 09/14/2015 05:57 AM, Jiri Pirko wrote:
> Mon, Sep 14, 2015 at 01:52:23PM CEST, armbru@redhat.com wrote:
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
>> for two reasons.  One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than void *, which lets the compiler catch
>> more type errors.
>>
>> This commit only touches allocations with size arguments of the form
>> sizeof(T).  Same Coccinelle semantic patchas in commit b45c03f.
> 
>                                            ^ typo :)
> 

This typo is copy-pasted into ALL of your recent g_new() cleanups. Since
you did scattershot threads across multiple maintainers rather than one
big thread, it may be a bit harder to plug all the instances before they
get pulled through the various trees.

> 
> Other than that:
> 
> Acked-by: Jiri Pirko <jiri@resnulli.us>

Reviewed-by: Eric Blake <eblake@redhat.com>

[In qemu, we tend to use 'Reviewed-by' for "I've inspected the code and
agree it correctly does what the commit message claims", and the weaker
'Acked-by' for "I agree with the fix as documented in the commit message
but didn't inspect the code to ensure that they match"]

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]