Re: [Qemu-devel] [PATCH] rocker: Use g_new() & friends where that makes obvious sense

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

On 09/14/2015 09:55 AM, Eric Blake wrote:
> On 09/14/2015 05:57 AM, Jiri Pirko wrote:
>> Mon, Sep 14, 2015 at 01:52:23PM CEST, armbru@redhat.com wrote:
>>> g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
>>> for two reasons.  One, it catches multiplication overflowing size_t.
>>> Two, it returns T * rather than void *, which lets the compiler catch
>>> more type errors.
>>>
>>> This commit only touches allocations with size arguments of the form
>>> sizeof(T).  Same Coccinelle semantic patchas in commit b45c03f.
>>
>>                                            ^ typo :)
>>
> 
> This typo is copy-pasted into ALL of your recent g_new() cleanups.

Actually, not all of them.

And when I first read your report of the typo, I was thinking that it
meant 'patches', although now I see that it should be two words 'patch as'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]