Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]

On 09/14/2015 09:51 AM, Eric Blake wrote:
> On 09/14/2015 05:53 AM, Markus Armbruster wrote:
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
>> for two reasons.  One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than void *, which lets the compiler catch
>> more type errors.
>>
>> This commit only touches allocations with size arguments of the form
>> sizeof(T).  Same Coccinelle semantic patchas in commit b45c03f.

s/patchas/patch as/

>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  linux-user/elfload.c | 2 +-
>>  linux-user/main.c    | 2 +-
>>  linux-user/syscall.c | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]