Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense

[Markus Armbruster <armbru@redhat.com>]

Stefan Weil <sw@weilnetz.de> writes:

> Am 24.09.2015 um 09:06 schrieb Markus Armbruster:
>> Ping?
>> 
>> Markus Armbruster <armbru@redhat.com> writes:
>> 
>>> g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also 
>>> safer, for two reasons.  One, it catches multiplication 
>>> overflowing size_t. Two, it returns T * rather than void *,
>>> which lets the compiler catch more type errors.
>>> 
>>> This commit only touches allocations with size arguments of the 
>>> form sizeof(T).  Same Coccinelle semantic patchas in commit 
>>> b45c03f.
>>> 
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com> --- 
>>> linux-user/elfload.c | 2 +- linux-user/main.c    | 2 +- 
>>> linux-user/syscall.c | 2 +- 3 files changed, 3 insertions(+), 3 
>>> deletions(-)
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> This patch is trivial enough for qemu-trivial.

I guess it is.  For code with a maintainer, I tend to try the maintainer
first.

> As Eric has written, the commit message needs
> a small correction: s/patchas/patch as/

Yes.