All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot
Date: Mon, 14 Sep 2015 14:21:11 -0700	[thread overview]
Message-ID: <55F73A47.9070900@gmail.com> (raw)
In-Reply-To: <20150914204833.GA53555@google.com>

On 14/09/15 13:48, Brian Norris wrote:
> On Mon, Sep 14, 2015 at 12:52:49PM -0700, Florian Fainelli wrote:
>> Call brcmstb_biuctrl_init() in brcmstb's init_irq machine descriptor
>> callback since we need to setup the Bus Interface Unit before SMP in
>> particular, but we also need to be able to remap registers.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> +static void __init brcmstb_init_irq(void)
>> +{
>> +	irqchip_init();
>> +	brcmstb_biuctrl_init();
> 
> I believe you're introducing a dependency on CONFIG_SOC_BRCMSTB, but
> it's not represented in Kconfig. Maybe SOC_BRCMSTB shouldn't be
> user-selectable, and it should just be select-ed by ARCH_BRCMSTB?

It is thanks to your previous commit, which is why I mentioned in the
cover letter that this was based on the 'soc/next' branch.

https://github.com/Broadcom/stblinux/commit/b19826efa15f94084416d5fc7749c45eabfbee36

Thanks for taking a look though!
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot
Date: Mon, 14 Sep 2015 14:21:11 -0700	[thread overview]
Message-ID: <55F73A47.9070900@gmail.com> (raw)
In-Reply-To: <20150914204833.GA53555-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

On 14/09/15 13:48, Brian Norris wrote:
> On Mon, Sep 14, 2015 at 12:52:49PM -0700, Florian Fainelli wrote:
>> Call brcmstb_biuctrl_init() in brcmstb's init_irq machine descriptor
>> callback since we need to setup the Bus Interface Unit before SMP in
>> particular, but we also need to be able to remap registers.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>> +static void __init brcmstb_init_irq(void)
>> +{
>> +	irqchip_init();
>> +	brcmstb_biuctrl_init();
> 
> I believe you're introducing a dependency on CONFIG_SOC_BRCMSTB, but
> it's not represented in Kconfig. Maybe SOC_BRCMSTB shouldn't be
> user-selectable, and it should just be select-ed by ARCH_BRCMSTB?

It is thanks to your previous commit, which is why I mentioned in the
cover letter that this was based on the 'soc/next' branch.

https://github.com/Broadcom/stblinux/commit/b19826efa15f94084416d5fc7749c45eabfbee36

Thanks for taking a look though!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-09-14 21:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 19:52 [PATCH 0/3] ARM: brcmstb: Bus Interface Unit support Florian Fainelli
2015-09-14 19:52 ` Florian Fainelli
2015-09-14 19:52 ` [PATCH 1/3] Documentation: bindings: brcmstb: Document write-pairing Florian Fainelli
2015-09-14 19:52   ` Florian Fainelli
2015-09-14 20:36   ` Rob Herring
2015-09-14 20:36     ` Rob Herring
2015-09-14 21:21     ` Florian Fainelli
2015-09-14 21:21       ` Florian Fainelli
2015-09-14 19:52 ` [PATCH 2/3] soc: brcmstb: Add Bus Interface Unit control setup Florian Fainelli
2015-09-14 19:52   ` Florian Fainelli
2015-09-14 19:52 ` [PATCH 3/3] ARM: brcmstb: Setup BIU control registers during boot Florian Fainelli
2015-09-14 19:52   ` Florian Fainelli
2015-09-14 20:48   ` Brian Norris
2015-09-14 20:48     ` Brian Norris
2015-09-14 21:21     ` Florian Fainelli [this message]
2015-09-14 21:21       ` Florian Fainelli
2015-09-14 21:29       ` Brian Norris
2015-09-14 21:29         ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F73A47.9070900@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.