From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
Cc: Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux
Date: Tue, 15 Sep 2015 21:12:18 -0700 [thread overview]
Message-ID: <55F8EC22.7020909@wwwdotorg.org> (raw)
In-Reply-To: <9D45476C-88E2-4F76-AB55-9D0C7194E29C-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
On 09/04/2015 01:26 AM, Martin Sperl wrote:
>
>> On 26.08.2015, at 03:44, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable@0x7e215004 {
>>> + compatible = "bcrm,bcm2835-aux";
>>> + reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
>
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
>
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.
The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux
Date: Tue, 15 Sep 2015 21:12:18 -0700 [thread overview]
Message-ID: <55F8EC22.7020909@wwwdotorg.org> (raw)
In-Reply-To: <9D45476C-88E2-4F76-AB55-9D0C7194E29C@martin.sperl.org>
On 09/04/2015 01:26 AM, Martin Sperl wrote:
>
>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel at martin.sperl.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable at 0x7e215004 {
>>> + compatible = "bcrm,bcm2835-aux";
>>> + reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
>
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
>
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.
The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Martin Sperl <kernel@martin.sperl.org>
Cc: Lee Jones <lee@kernel.org>, Russell King <linux@arm.linux.org.uk>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux
Date: Tue, 15 Sep 2015 21:12:18 -0700 [thread overview]
Message-ID: <55F8EC22.7020909@wwwdotorg.org> (raw)
In-Reply-To: <9D45476C-88E2-4F76-AB55-9D0C7194E29C@martin.sperl.org>
On 09/04/2015 01:26 AM, Martin Sperl wrote:
>
>> On 26.08.2015, at 03:44, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>
>> On 08/24/2015 02:40 AM, kernel@martin.sperl.org wrote:
>>
>>> +Example:
>>> +
>>> +aux_enable: aux_enable@0x7e215004 {
>>> + compatible = "bcrm,bcm2835-aux";
>>> + reg = <0x7e215004 0x04>;
>>
>> I'd expect that to be <0x7e215000 0x8>;
>
> The reason is that we just handle enable with this driver,
> which just requires access to the 0x7e215004 register.
>
> The 0x7e215000 register (interrupt mask) could be used by a
> cascaded interrupt-controller, but as the spi and uart drivers
> can run with shared interrupts this is not a necessity.
The DT is supposed to describe the HW, not any particular SW's use of
the HW. If the HW block has 2 registers, so must the DT reg property.
next prev parent reply other threads:[~2015-09-16 4:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 8:40 [PATCH v4 0/5] bcm2835: auxiliar device support for spi kernel-TqfNSX0MhmxHKSADF0wUEw
2015-08-24 8:40 ` kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
2015-08-24 8:40 ` [PATCH v4 1/5] soc: bcm2835: auxiliar devices enable infrastructure kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
[not found] ` <1440405608-3995-2-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-08-26 1:52 ` Stephen Warren
2015-08-26 1:52 ` Stephen Warren
2015-08-26 1:52 ` Stephen Warren
2015-08-24 8:40 ` [PATCH v4 2/5] ARM: bcm2835: add DT for the bcm2835 auxiliar devices kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
2015-08-24 8:40 ` [PATCH v4 3/5] dt/bindings: bcm2835: add binding documentation for bcm2835-aux kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
[not found] ` <1440405608-3995-4-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-08-26 1:44 ` Stephen Warren
2015-08-26 1:44 ` Stephen Warren
2015-08-26 1:44 ` Stephen Warren
2015-09-04 8:26 ` Martin Sperl
2015-09-04 8:26 ` Martin Sperl
[not found] ` <9D45476C-88E2-4F76-AB55-9D0C7194E29C-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-09-16 4:12 ` Stephen Warren [this message]
2015-09-16 4:12 ` Stephen Warren
2015-09-16 4:12 ` Stephen Warren
[not found] ` <55F8EC22.7020909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-09-16 5:25 ` Martin Sperl
2015-09-16 5:25 ` Martin Sperl
2015-09-16 5:25 ` Martin Sperl
2015-08-24 8:40 ` [PATCH v4 4/5] spi: bcm2835: new driver implementing auxiliar spi1/spi2 on the bcm2835 soc kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
[not found] ` <1440405608-3995-5-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-08-26 1:56 ` Stephen Warren
2015-08-26 1:56 ` Stephen Warren
2015-08-26 1:56 ` Stephen Warren
[not found] ` <1440405608-3995-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-08-24 8:40 ` [PATCH v4 5/5] dt/bindings: bcm2835: Add binding documentation for auxiliar spi devices kernel-TqfNSX0MhmxHKSADF0wUEw
2015-08-24 8:40 ` kernel
2015-08-24 8:40 ` kernel at martin.sperl.org
[not found] ` <1440405608-3995-6-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2015-08-26 1:49 ` Stephen Warren
2015-08-26 1:49 ` Stephen Warren
2015-08-26 1:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F8EC22.7020909@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
--cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.