From: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
y2038-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
Mauro Carvalho Chehab
<mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized
Date: Wed, 16 Sep 2015 10:55:40 +0200 [thread overview]
Message-ID: <55F92E8C.3020701@samsung.com> (raw)
In-Reply-To: <1442332148-488079-5-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
On 15/09/15 17:49, Arnd Bergmann wrote:
> The exynos4 fimc capture driver claims to use monotonic
> timestamps but calls ktime_get_real_ts(). This is both
> an incorrect API use, and a bad idea because of the y2038
> problem and the fact that the wall clock time is not reliable
> for timestamps across suspend or settimeofday().
>
> This changes the driver to use the normal v4l2_get_timestamp()
> function like all other drivers.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Acked-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, y2038@lists.linaro.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-api@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized
Date: Wed, 16 Sep 2015 10:55:40 +0200 [thread overview]
Message-ID: <55F92E8C.3020701@samsung.com> (raw)
In-Reply-To: <1442332148-488079-5-git-send-email-arnd@arndb.de>
On 15/09/15 17:49, Arnd Bergmann wrote:
> The exynos4 fimc capture driver claims to use monotonic
> timestamps but calls ktime_get_real_ts(). This is both
> an incorrect API use, and a bad idea because of the y2038
> problem and the fact that the wall clock time is not reliable
> for timestamps across suspend or settimeofday().
>
> This changes the driver to use the normal v4l2_get_timestamp()
> function like all other drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
next prev parent reply other threads:[~2015-09-16 8:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 15:49 [PATCH 0/7] [media] y2038 conversion for subsystem Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
2015-09-15 15:49 ` [PATCH 1/7] [media] dvb: use ktime_t for internal timeout Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
2015-09-15 17:55 ` Andreas Oberritter
2015-09-15 17:55 ` Andreas Oberritter
[not found] ` <55F85B97.8000700-p6skyjIMMCQb1SvskN2V4Q@public.gmane.org>
2015-09-15 20:30 ` [Y2038] " Arnd Bergmann
2015-09-15 20:30 ` Arnd Bergmann
2015-09-15 15:49 ` [PATCH 2/7] [media] dvb: remove unused systime() function Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
2015-09-15 15:49 ` [PATCH 3/7] [media] dvb: don't use 'time_t' in event ioctl Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
2017-08-28 15:32 ` [3/7,media] " Eugene Syromiatnikov
2017-08-30 20:25 ` Arnd Bergmann
2017-08-31 13:10 ` Eugene Syromiatnikov
2015-09-15 15:49 ` [PATCH 4/7] [media] exynos4-is: use monotonic timestamps as advertized Arnd Bergmann
[not found] ` <1442332148-488079-5-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2015-09-16 8:55 ` Sylwester Nawrocki [this message]
2015-09-16 8:55 ` Sylwester Nawrocki
2015-09-15 15:49 ` [PATCH 5/7] [media] use v4l2_get_timestamp where possible Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
[not found] ` <1442332148-488079-6-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2015-09-16 8:57 ` Sylwester Nawrocki
2015-09-16 8:57 ` Sylwester Nawrocki
2015-09-15 15:49 ` [PATCH 6/7] [RFC] [media]: v4l2: introduce v4l2_timeval Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
[not found] ` <1442332148-488079-7-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2015-09-15 16:27 ` Hans Verkuil
2015-09-15 16:27 ` Hans Verkuil
2015-09-15 20:26 ` Arnd Bergmann
2015-09-15 20:26 ` Arnd Bergmann
2015-09-16 6:51 ` Hans Verkuil
[not found] ` <55F91162.8030002-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2015-09-16 7:56 ` Arnd Bergmann
2015-09-16 7:56 ` Arnd Bergmann
2015-09-16 8:12 ` Hans Verkuil
2015-09-16 8:12 ` Hans Verkuil
[not found] ` <55F92450.8010802-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2015-09-16 8:40 ` Arnd Bergmann
2015-09-16 8:40 ` Arnd Bergmann
2015-09-15 15:49 ` [PATCH 7/7] [RFC] [media] introduce v4l2_timespec type for timestamps Arnd Bergmann
2015-09-15 15:49 ` Arnd Bergmann
2015-09-15 16:32 ` Hans Verkuil
2015-09-15 20:27 ` Arnd Bergmann
2015-09-15 20:27 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F92E8C.3020701@samsung.com \
--to=s.nawrocki-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=y2038-cunTk1MwBs8s++Sfvej+rw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.