From: Leon Alrae <leon.alrae@imgtec.com>
To: Alex Smith <alex.smith@imgtec.com>,
qemu-devel@nongnu.org, Alex Smith <alex@alex-smith.me.uk>
Subject: Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count
Date: Wed, 16 Sep 2015 10:05:19 +0100 [thread overview]
Message-ID: <55F930CF.9010107@imgtec.com> (raw)
In-Reply-To: <20150916052740.GB12445@aurel32.net>
On 16/09/15 06:27, Aurelien Jarno wrote:
> Independently of your patch, I do wonder if we shouldn't change the
> return type of cpu_mips_get_count to int32_t. With your patch, there
> are now 2 calls to this functions, and both cast the value to int32_t.
Yes, I think that will make more sense if the return type of
cpu_mips_get_count() matches CP0_Count.
Leon
prev parent reply other threads:[~2015-09-16 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 10:34 [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count Alex Smith
2015-09-08 11:34 ` Leon Alrae
2015-09-16 5:27 ` Aurelien Jarno
2015-09-16 9:05 ` Leon Alrae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F930CF.9010107@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=alex.smith@imgtec.com \
--cc=alex@alex-smith.me.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.