From: Vignesh R <vigneshr@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>, <hramrach@gmail.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request
Date: Wed, 16 Sep 2015 15:37:11 +0530 [thread overview]
Message-ID: <55F93F4F.1010704@ti.com> (raw)
In-Reply-To: <20150914182704.GD12027@sirena.org.uk>
On 09/14/2015 11:57 PM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:
>
>> + if (spi->master->spi_mtd_mmap_read) {
>> + return spi->master->spi_mtd_mmap_read(spi, from, len,
>> + retlen, buf,
>> + nor->read_opcode,
>> + nor->addr_width,
>> + dummy);
>> + }
>
> We should be calling some API provided by the SPI core here, not peering
> directly into the ops struture.
>
Ok..
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
hramrach@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request
Date: Wed, 16 Sep 2015 15:37:11 +0530 [thread overview]
Message-ID: <55F93F4F.1010704@ti.com> (raw)
In-Reply-To: <20150914182704.GD12027@sirena.org.uk>
On 09/14/2015 11:57 PM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:
>
>> + if (spi->master->spi_mtd_mmap_read) {
>> + return spi->master->spi_mtd_mmap_read(spi, from, len,
>> + retlen, buf,
>> + nor->read_opcode,
>> + nor->addr_width,
>> + dummy);
>> + }
>
> We should be calling some API provided by the SPI core here, not peering
> directly into the ops struture.
>
Ok..
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request
Date: Wed, 16 Sep 2015 15:37:11 +0530 [thread overview]
Message-ID: <55F93F4F.1010704@ti.com> (raw)
In-Reply-To: <20150914182704.GD12027@sirena.org.uk>
On 09/14/2015 11:57 PM, Mark Brown wrote:
> On Fri, Sep 04, 2015 at 02:00:00PM +0530, Vignesh R wrote:
>
>> + if (spi->master->spi_mtd_mmap_read) {
>> + return spi->master->spi_mtd_mmap_read(spi, from, len,
>> + retlen, buf,
>> + nor->read_opcode,
>> + nor->addr_width,
>> + dummy);
>> + }
>
> We should be calling some API provided by the SPI core here, not peering
> directly into the ops struture.
>
Ok..
--
Regards
Vignesh
next prev parent reply other threads:[~2015-09-16 10:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 8:29 [PATCH 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` [PATCH 1/5] spi: introduce mmap read support for spi flash devices Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 11:25 ` Jagan Teki
2015-09-04 11:25 ` Jagan Teki
2015-09-04 11:25 ` Jagan Teki
2015-09-14 18:35 ` Mark Brown
2015-09-14 18:35 ` Mark Brown
2015-09-14 18:35 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
2015-09-16 10:07 ` Vignesh R
2015-09-16 10:07 ` Vignesh R
2015-09-16 12:46 ` Jagan Teki
2015-09-16 12:46 ` Jagan Teki
2015-09-16 12:46 ` Jagan Teki
2015-09-16 15:24 ` Mark Brown
2015-09-16 15:24 ` Mark Brown
2015-09-16 15:24 ` Mark Brown
2015-09-16 15:30 ` Michal Suchanek
2015-09-16 15:30 ` Michal Suchanek
2015-09-16 15:30 ` Michal Suchanek
2015-09-14 18:37 ` Mark Brown
2015-09-14 18:37 ` Mark Brown
2015-09-16 10:08 ` Vignesh R
2015-09-16 10:08 ` Vignesh R
2015-09-16 10:08 ` Vignesh R
2015-09-16 10:56 ` Mark Brown
2015-09-16 10:56 ` Mark Brown
2015-09-16 10:56 ` Mark Brown
2015-09-18 12:10 ` Vignesh R
2015-09-18 12:10 ` Vignesh R
2015-09-18 12:10 ` Vignesh R
2015-09-04 8:29 ` [PATCH 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-04 8:29 ` Vignesh R
2015-09-14 18:26 ` Mark Brown
2015-09-14 18:26 ` Mark Brown
2015-09-16 10:07 ` Vignesh R
2015-09-16 10:07 ` Vignesh R
2015-09-16 10:07 ` Vignesh R
2015-09-04 8:30 ` [PATCH 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-14 18:27 ` Mark Brown
2015-09-14 18:27 ` Mark Brown
2015-09-14 18:27 ` Mark Brown
2015-09-16 10:07 ` Vignesh R [this message]
2015-09-16 10:07 ` Vignesh R
2015-09-16 10:07 ` Vignesh R
2015-09-04 8:30 ` [PATCH 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` [PATCH 5/5] ARM: dts: AM4372: " Vignesh R
2015-09-04 8:30 ` Vignesh R
2015-09-04 8:30 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F93F4F.1010704@ti.com \
--to=vigneshr@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.