All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	 Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-trivial@nongnu.org, Peter Chubb <peter.chubb@nicta.com.au>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [Qemu-trivial] [PATCH] imx_serial: Generate interrupt on tx empty if enabled
Date: Wed, 16 Sep 2015 13:28:04 +0300	[thread overview]
Message-ID: <55F94434.10603@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAPokK=oHBqhrwXgx5VM3xHFqu2KTtBfOikhQbSUy5azRTO2LsA@mail.gmail.com>

13.09.2015 23:17, Peter Crosthwaite wrote:
> On Fri, Sep 11, 2015 at 12:37 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>
>> Can we please have some r-b or ACK for this? :)
>>
>> 20.08.2015 18:52, Guenter Roeck wrote:
>>> Generate an interrupt if the tx buffer is empty and the tx empty interrupt
>>> is enabled. This fixes a problem seen when running a Linux image since
>>> Linux commit 55c3cb1358e ("serial: imx: remove unneeded imx_transmit_buffer()
>>> from imx_start_tx()"). Linux now waits for the tx empty interrupt before
>>> starting to send data, causing transmit stalls until there is an interrupt
>>> for another reason.
>>>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Looks right, Jean-Christophe may know more though.

Thanks, applied to the trivial-patches tree :)

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-trivial@nongnu.org, Peter Chubb <peter.chubb@nicta.com.au>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [Qemu-devel] [PATCH] imx_serial: Generate interrupt on tx empty if enabled
Date: Wed, 16 Sep 2015 13:28:04 +0300	[thread overview]
Message-ID: <55F94434.10603@msgid.tls.msk.ru> (raw)
In-Reply-To: <CAPokK=oHBqhrwXgx5VM3xHFqu2KTtBfOikhQbSUy5azRTO2LsA@mail.gmail.com>

13.09.2015 23:17, Peter Crosthwaite wrote:
> On Fri, Sep 11, 2015 at 12:37 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>
>> Can we please have some r-b or ACK for this? :)
>>
>> 20.08.2015 18:52, Guenter Roeck wrote:
>>> Generate an interrupt if the tx buffer is empty and the tx empty interrupt
>>> is enabled. This fixes a problem seen when running a Linux image since
>>> Linux commit 55c3cb1358e ("serial: imx: remove unneeded imx_transmit_buffer()
>>> from imx_start_tx()"). Linux now waits for the tx empty interrupt before
>>> starting to send data, causing transmit stalls until there is an interrupt
>>> for another reason.
>>>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Looks right, Jean-Christophe may know more though.

Thanks, applied to the trivial-patches tree :)

/mjt

  reply	other threads:[~2015-09-16 10:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 15:52 [Qemu-trivial] [PATCH] imx_serial: Generate interrupt on tx empty if enabled Guenter Roeck
2015-08-20 15:52 ` [Qemu-devel] " Guenter Roeck
2015-09-11  7:37 ` [Qemu-trivial] " Michael Tokarev
2015-09-11  7:37   ` [Qemu-devel] " Michael Tokarev
2015-09-13 20:17   ` [Qemu-trivial] " Peter Crosthwaite
2015-09-13 20:17     ` Peter Crosthwaite
2015-09-16 10:28     ` Michael Tokarev [this message]
2015-09-16 10:28       ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F94434.10603@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=crosthwaitepeter@gmail.com \
    --cc=jcd@tribudubois.net \
    --cc=linux@roeck-us.net \
    --cc=peter.chubb@nicta.com.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.