Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

On 09/16/2015 07:52 AM, Daniel P. Berrange wrote:
> The nbd block driver currently uses a QemuOpts object
> when setting up sockets. Switch it over to use the
> QAPI SocketAddress object instead.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  block/nbd.c | 69 +++++++++++++++++++++++++++++++++----------------------------
>  1 file changed, 37 insertions(+), 32 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Wen - this patch will help in your efforts to expose NBD via
blockdev-add QMP.

> -    if (!qemu_opt_get(s->socket_opts, "port")) {
> -        qemu_opt_set_number(s->socket_opts, "port", NBD_DEFAULT_PORT,
> -                            &error_abort);
> -    }
> +    s->client.is_unix = saddr->kind == SOCKET_ADDRESS_KIND_UNIX;
>  

Minor conflict with my pending patch to rename the C representation of
qapi unions to spell things with 'type':
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg02598.html
but as that needs to be rebased once Markus' introspection lands, you
don't have to wait for it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]