From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object
Date: Wed, 16 Sep 2015 16:21:39 +0200 [thread overview]
Message-ID: <55F97AF3.4060700@redhat.com> (raw)
In-Reply-To: <1442411543-28513-2-git-send-email-berrange@redhat.com>
On 16/09/2015 15:52, Daniel P. Berrange wrote:
> + saddr = nbd_config(s, options, &export, &local_err);
You can use errp directly here. Otherwise looks fine.
Paolo
> + if (!saddr) {
> error_propagate(errp, local_err);
> return -EINVAL;
> }
next prev parent reply other threads:[~2015-09-16 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 13:52 [Qemu-devel] [PATCH v1 0/2] Remove use of QemuOpts from the nbd code Daniel P. Berrange
2015-09-16 13:52 ` [Qemu-devel] [PATCH v1 1/2] nbd: convert to use the QAPI SocketAddress object Daniel P. Berrange
2015-09-16 14:02 ` Eric Blake
2015-09-16 14:21 ` Paolo Bonzini [this message]
2015-09-16 13:52 ` [Qemu-devel] [PATCH v1 2/2] qemu-nbd: " Daniel P. Berrange
2015-09-16 14:08 ` Eric Blake
2015-09-16 14:13 ` Daniel P. Berrange
2015-09-16 14:23 ` Paolo Bonzini
2015-09-16 14:24 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F97AF3.4060700@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.