All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki.Poulose@arm.com (Suzuki K. Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm64: cpuinfo: reduce cache contention on update_{feature}_support
Date: Wed, 16 Sep 2015 15:49:14 +0100	[thread overview]
Message-ID: <55F9816A.9080405@arm.com> (raw)
In-Reply-To: <20150904195240.GA14679@yury-N73SV>

On 04/09/15 20:52, Yury Norov wrote:
> On Fri, Sep 04, 2015 at 05:40:57PM +0100, Suzuki K. Poulose wrote:
>> On 04/09/15 17:04, Yury Norov wrote:
>>> This patch is on top of https://lkml.org/lkml/2015/9/2/413
>>>
>>> In master, there's only a single function -
>>> 	update_mixed_endian_el0_support
>>> And similar function is on review mentioned above.
>>>
>>> The algorithm for them is like this:
>>>   - there's system-wide boolean marker for the feature that is
>>>     initially enabled;
>>>   - there's also updater for the feature that may disable it
>>>     system-widely if feature is not supported on current CPU.
>>>   - updater is called for each CPU on bootup.
>>>
>>> The problem is the way updater does its work. On each CPU, it
>>> unconditionally updates system-wide marker. For multi-core
>>> system it makes CPU issue invalidate message for a cache
>>> line containing marker. This invalidate increases cache
>>> contention for nothing, because there's a single marker reset
>>> that is really needed, and the others are useless.
>>>
>>> If the number of system-wide markers of this sort will grow,
>>> it may become a trouble on large-scale SOCs. The fix is trivial,
>>> though: do system-wide marker update conditionally, and preserve
>>> corresponding cache line in shared state for all update() calls,
>>> except, probably, one.
>>
>> As I have mentioned already, this patch (and the per feature functions)
>> won't be needed once we merge my series (which is waiting for the merge
>> window to see the public lights)
>>
>
> OK. Than waiting for your patchset.

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/370386.html

Cheers
Suzuki

WARNING: multiple messages have this Message-ID (diff)
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"klimov.linux@gmail.com" <klimov.linux@gmail.com>,
	"ddaney.cavm@gmail.com" <ddaney.cavm@gmail.com>,
	"yury.norov@gmail.com" <yury.norov@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH] arm64: cpuinfo: reduce cache contention on update_{feature}_support
Date: Wed, 16 Sep 2015 15:49:14 +0100	[thread overview]
Message-ID: <55F9816A.9080405@arm.com> (raw)
In-Reply-To: <20150904195240.GA14679@yury-N73SV>

On 04/09/15 20:52, Yury Norov wrote:
> On Fri, Sep 04, 2015 at 05:40:57PM +0100, Suzuki K. Poulose wrote:
>> On 04/09/15 17:04, Yury Norov wrote:
>>> This patch is on top of https://lkml.org/lkml/2015/9/2/413
>>>
>>> In master, there's only a single function -
>>> 	update_mixed_endian_el0_support
>>> And similar function is on review mentioned above.
>>>
>>> The algorithm for them is like this:
>>>   - there's system-wide boolean marker for the feature that is
>>>     initially enabled;
>>>   - there's also updater for the feature that may disable it
>>>     system-widely if feature is not supported on current CPU.
>>>   - updater is called for each CPU on bootup.
>>>
>>> The problem is the way updater does its work. On each CPU, it
>>> unconditionally updates system-wide marker. For multi-core
>>> system it makes CPU issue invalidate message for a cache
>>> line containing marker. This invalidate increases cache
>>> contention for nothing, because there's a single marker reset
>>> that is really needed, and the others are useless.
>>>
>>> If the number of system-wide markers of this sort will grow,
>>> it may become a trouble on large-scale SOCs. The fix is trivial,
>>> though: do system-wide marker update conditionally, and preserve
>>> corresponding cache line in shared state for all update() calls,
>>> except, probably, one.
>>
>> As I have mentioned already, this patch (and the per feature functions)
>> won't be needed once we merge my series (which is waiting for the merge
>> window to see the public lights)
>>
>
> OK. Than waiting for your patchset.

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/370386.html

Cheers
Suzuki


  reply	other threads:[~2015-09-16 14:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 16:04 [RFC PATCH] arm64: cpuinfo: reduce cache contention on update_{feature}_support Yury Norov
2015-09-04 16:04 ` Yury Norov
2015-09-04 16:36 ` David Daney
2015-09-04 16:36   ` David Daney
2015-09-07  8:56   ` Catalin Marinas
2015-09-07  8:56     ` Catalin Marinas
2015-09-04 16:40 ` Suzuki K. Poulose
2015-09-04 16:40   ` Suzuki K. Poulose
2015-09-04 19:52   ` Yury Norov
2015-09-04 19:52     ` Yury Norov
2015-09-16 14:49     ` Suzuki K. Poulose [this message]
2015-09-16 14:49       ` Suzuki K. Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F9816A.9080405@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.