From: Paolo Bonzini <pbonzini@redhat.com>
To: Marc Zyngier <marc.zyngier@arm.com>, Gleb Natapov <gleb@kernel.org>
Cc: "Christoffer Dall" <christoffer.dall@linaro.org>,
"Will Deacon" <will.deacon@arm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marek Majtyka" <marek.majtyka@tieto.com>,
"Pavel Fedin" <p.fedin@samsung.com>,
"Ming Lei" <ming.lei@canonical.com>,
kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] arm64: KVM: Disable virtual timer even if the guest is not using it
Date: Thu, 17 Sep 2015 17:31:02 +0200 [thread overview]
Message-ID: <55FADCB6.8010100@redhat.com> (raw)
In-Reply-To: <55FADC1E.50909@arm.com>
On 17/09/2015 17:28, Marc Zyngier wrote:
> > diff --git a/arch/arm/kvm/interrupts_head.S b/arch/arm/kvm/interrupts_head.S
> > index 702740d37465..93e322b4d242 100644
> > --- a/arch/arm/kvm/interrupts_head.S
> > +++ b/arch/arm/kvm/interrupts_head.S
> > @@ -514,6 +514,7 @@ ARM_BE8(rev r6, r6 )
> > beq 1f
> >
> > mrc p15, 0, r2, c14, c3, 1 @ CNTV_CTL
> > + and r2, r2, #3
>
> I don't think we need this. Exposing the ISTATUS bit to the kernel (or
> even userspace) is not really a problem (that's actually an interesting
> piece of information), and restoring it is not possible since it is
> read-only.
>
> We should drop the equivalent 'and' from the arm64 version.
Ok. I'll resend the thing as a proper patch.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] arm64: KVM: Disable virtual timer even if the guest is not using it
Date: Thu, 17 Sep 2015 17:31:02 +0200 [thread overview]
Message-ID: <55FADCB6.8010100@redhat.com> (raw)
In-Reply-To: <55FADC1E.50909@arm.com>
On 17/09/2015 17:28, Marc Zyngier wrote:
> > diff --git a/arch/arm/kvm/interrupts_head.S b/arch/arm/kvm/interrupts_head.S
> > index 702740d37465..93e322b4d242 100644
> > --- a/arch/arm/kvm/interrupts_head.S
> > +++ b/arch/arm/kvm/interrupts_head.S
> > @@ -514,6 +514,7 @@ ARM_BE8(rev r6, r6 )
> > beq 1f
> >
> > mrc p15, 0, r2, c14, c3, 1 @ CNTV_CTL
> > + and r2, r2, #3
>
> I don't think we need this. Exposing the ISTATUS bit to the kernel (or
> even userspace) is not really a problem (that's actually an interesting
> piece of information), and restoring it is not possible since it is
> read-only.
>
> We should drop the equivalent 'and' from the arm64 version.
Ok. I'll resend the thing as a proper patch.
Paolo
next prev parent reply other threads:[~2015-09-17 15:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 14:46 [GIT PULL] Second set of KVM/ARM updates for 4.3-rc2 Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 1/8] KVM: arm64: add workaround for Cortex-A57 erratum #852523 Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 2/8] arm64: KVM: Fix user access for debug registers Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 3/8] arm: KVM: Fix incorrect device to IPA mapping Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 4/8] arm/arm64: KVM: vgic: Check for !irqchip_in_kernel() when mapping resources Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 5/8] arm64: KVM: Disable virtual timer even if the guest is not using it Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 15:02 ` Paolo Bonzini
2015-09-17 15:02 ` Paolo Bonzini
2015-09-17 15:28 ` Marc Zyngier
2015-09-17 15:28 ` Marc Zyngier
2015-09-17 15:31 ` Paolo Bonzini [this message]
2015-09-17 15:31 ` Paolo Bonzini
2015-09-17 14:46 ` [PATCH 6/8] arm: " Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 7/8] arm64: KVM: Remove all traces of the ThumbEE registers Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:46 ` [PATCH 8/8] arm/arm64: KVM: Remove 'config KVM_ARM_MAX_VCPUS' Marc Zyngier
2015-09-17 14:46 ` Marc Zyngier
2015-09-17 14:53 ` [GIT PULL] Second set of KVM/ARM updates for 4.3-rc2 Paolo Bonzini
2015-09-17 14:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FADCB6.8010100@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=marek.majtyka@tieto.com \
--cc=ming.lei@canonical.com \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.