From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Andreas Faerber <afaerber@suse.de>,
Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU
Date: Thu, 17 Sep 2015 10:44:40 -0600 [thread overview]
Message-ID: <55FAEDF8.70604@redhat.com> (raw)
In-Reply-To: <55FAEB33.50809@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On 09/17/2015 10:32 AM, Paolo Bonzini wrote:
>>>> Can we revert this one, please? Checkpatch now warns about constructs
>>>> like
>>>> typedef struct MyDevice {
>>>> DeviceState parent;
>>>>
>>>> int reg0, reg1, reg2;
>>>> } MyDevice;
>>>
>>> It's interesting that qom/object.h documents this and start like:
>>>
>>> typedef struct ObjectClass ObjectClass;
> I think it varies depending on the maintainer. PPC, USB, SCSI, ACPI all
> use a separate typedef. I'll prepare a revert.
And qapi is about to switch from inline to separate:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04291.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-09-17 16:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 9:53 [Qemu-devel] [PATCH 0/4] updates to coding style and checkpatch Paolo Bonzini
2015-09-07 9:53 ` [Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules Paolo Bonzini
2015-09-09 9:20 ` Stefan Hajnoczi
2015-09-09 10:43 ` Alex Bennée
2015-09-07 9:53 ` [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules Paolo Bonzini
2015-09-07 13:18 ` Thomas Huth
2015-09-07 14:22 ` Paolo Bonzini
2015-09-07 14:37 ` Thomas Huth
2015-09-07 15:23 ` Markus Armbruster
2015-09-07 16:06 ` Paolo Bonzini
2015-09-07 17:05 ` Markus Armbruster
2015-09-09 16:26 ` John Snow
2015-09-09 17:22 ` Peter Maydell
2015-09-09 19:23 ` Eduardo Habkost
2015-09-09 20:28 ` Paolo Bonzini
2015-09-09 19:09 ` Eduardo Habkost
2015-09-07 17:02 ` Thomas Huth
2015-09-09 18:45 ` Eduardo Habkost
2015-09-07 15:17 ` Markus Armbruster
2015-09-07 15:54 ` Paolo Bonzini
2015-09-07 16:59 ` Markus Armbruster
2015-09-07 9:53 ` [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU Paolo Bonzini
2015-09-09 9:22 ` Stefan Hajnoczi
2015-09-17 14:24 ` Peter Maydell
2015-09-17 16:00 ` Paolo Bonzini
2015-09-17 16:16 ` Peter Maydell
2015-09-17 16:32 ` Paolo Bonzini
2015-09-17 16:44 ` Eric Blake [this message]
2015-09-18 6:53 ` Markus Armbruster
2015-10-04 18:44 ` Peter Maydell
2015-10-05 18:11 ` Eduardo Habkost
2015-10-05 18:47 ` Peter Maydell
2015-10-05 19:27 ` Paolo Bonzini
2015-09-07 9:53 ` [Qemu-devel] [PATCH 4/4] checkpatch: remove tests that are not relevant outside the kernel Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAEDF8.70604@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.