Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

[Paolo Bonzini <pbonzini@redhat.com>]

On 05/10/2015 20:47, Peter Maydell wrote:
> On 5 October 2015 at 19:11, Eduardo Habkost <ehabkost@redhat.com> wrote:
>> On Sun, Oct 04, 2015 at 07:44:29PM +0100, Peter Maydell wrote:
>>> On 17 September 2015 at 17:32, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>>
>>>>
>>>> On 17/09/2015 18:16, Peter Maydell wrote:
>>>>> On 17 September 2015 at 17:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 17/09/2015 16:24, Peter Maydell wrote:
>>>>>>> Can we revert this one, please? Checkpatch now warns about constructs
>>>>>>> like
>>>>>>>   typedef struct MyDevice {
>>>>>>>       DeviceState parent;
>>>>>>>
>>>>>>>       int reg0, reg1, reg2;
>>>>>>>   } MyDevice;
>>>
>>>> I think it varies depending on the maintainer.  PPC, USB, SCSI, ACPI all
>>>> use a separate typedef.  I'll prepare a revert.
>>>
>>> Ping on that revert patch? I can't find it onlist...
>>
>> The x86 pull request I sent today triggers this error, BTW. I hope it
>> won't make the pull request be automatically rejected.
> 
> Nope, because I don't run checkpatch on pull requests.

I've sent the patch today, by the way.  Sorry for the delay.

Paolo