From: rjui@broadcom.com (Ray Jui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: clean up Cygnus DT files
Date: Thu, 17 Sep 2015 18:20:36 -0700 [thread overview]
Message-ID: <55FB66E4.8010006@broadcom.com> (raw)
In-Reply-To: <55FB65E0.50407@gmail.com>
On 9/17/2015 6:16 PM, Florian Fainelli wrote:
> On 17/09/15 16:57, Ray Jui wrote:
>> This patch cleans up Cygnus DT files and makes the format consistent
>> with the rest of Broadcom iProc based SoCs.
>>
>> Changes include:
>> - Put core components into "core" node of type "simple-bus"
>> - Put all other peripherals into "soc" node of type "simple-bus"
>> - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts
>> files
>> - Ordered all device nodes under buses based on their base register
>> addresses
>> - Remove unused PCI I/O resource
>> - Use label instead of full path to reference device nodes in dts
>> files
>
> I am fine with the changes per-se, but the review is made largely more
> difficult because you mix multiple changes at the same time, this really
> ought to be separate patches to ease the review process. Sorry for not
> picking that up earlier.
Sure! I'll break them up into individual patches as follows:
- Put core components into "core" node of type "simple-bus"
- Put all other peripherals into "soc" node of type "simple-bus"
- Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts files
- Ordered all device nodes under buses based on their base register
addresses
- Remove unused PCI I/O resources
- Use label instead of full path to reference device nodes in dts files
Thanks!
Ray
WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] ARM: dts: clean up Cygnus DT files
Date: Thu, 17 Sep 2015 18:20:36 -0700 [thread overview]
Message-ID: <55FB66E4.8010006@broadcom.com> (raw)
In-Reply-To: <55FB65E0.50407-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 9/17/2015 6:16 PM, Florian Fainelli wrote:
> On 17/09/15 16:57, Ray Jui wrote:
>> This patch cleans up Cygnus DT files and makes the format consistent
>> with the rest of Broadcom iProc based SoCs.
>>
>> Changes include:
>> - Put core components into "core" node of type "simple-bus"
>> - Put all other peripherals into "soc" node of type "simple-bus"
>> - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts
>> files
>> - Ordered all device nodes under buses based on their base register
>> addresses
>> - Remove unused PCI I/O resource
>> - Use label instead of full path to reference device nodes in dts
>> files
>
> I am fine with the changes per-se, but the review is made largely more
> difficult because you mix multiple changes at the same time, this really
> ought to be separate patches to ease the review process. Sorry for not
> picking that up earlier.
Sure! I'll break them up into individual patches as follows:
- Put core components into "core" node of type "simple-bus"
- Put all other peripherals into "soc" node of type "simple-bus"
- Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts files
- Ordered all device nodes under buses based on their base register
addresses
- Remove unused PCI I/O resources
- Use label instead of full path to reference device nodes in dts files
Thanks!
Ray
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <rjui@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<bcm-kernel-feedback-list@broadcom.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/4] ARM: dts: clean up Cygnus DT files
Date: Thu, 17 Sep 2015 18:20:36 -0700 [thread overview]
Message-ID: <55FB66E4.8010006@broadcom.com> (raw)
In-Reply-To: <55FB65E0.50407@gmail.com>
On 9/17/2015 6:16 PM, Florian Fainelli wrote:
> On 17/09/15 16:57, Ray Jui wrote:
>> This patch cleans up Cygnus DT files and makes the format consistent
>> with the rest of Broadcom iProc based SoCs.
>>
>> Changes include:
>> - Put core components into "core" node of type "simple-bus"
>> - Put all other peripherals into "soc" node of type "simple-bus"
>> - Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts
>> files
>> - Ordered all device nodes under buses based on their base register
>> addresses
>> - Remove unused PCI I/O resource
>> - Use label instead of full path to reference device nodes in dts
>> files
>
> I am fine with the changes per-se, but the review is made largely more
> difficult because you mix multiple changes at the same time, this really
> ought to be separate patches to ease the review process. Sorry for not
> picking that up earlier.
Sure! I'll break them up into individual patches as follows:
- Put core components into "core" node of type "simple-bus"
- Put all other peripherals into "soc" node of type "simple-bus"
- Move aliases into bcm-cygnus.dtsi to avoid duplications in all dts files
- Ordered all device nodes under buses based on their base register
addresses
- Remove unused PCI I/O resources
- Use label instead of full path to reference device nodes in dts files
Thanks!
Ray
next prev parent reply other threads:[~2015-09-18 1:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 23:57 [PATCH 0/4] Broadcom Cygnus device tree changes Ray Jui
2015-09-17 23:57 ` Ray Jui
2015-09-17 23:57 ` Ray Jui
2015-09-17 23:57 ` [PATCH 1/4] ARM: dts: clean up Cygnus DT files Ray Jui
2015-09-17 23:57 ` Ray Jui
2015-09-17 23:57 ` Ray Jui
2015-09-18 1:16 ` Florian Fainelli
2015-09-18 1:16 ` Florian Fainelli
2015-09-18 1:20 ` Ray Jui [this message]
2015-09-18 1:20 ` Ray Jui
2015-09-18 1:20 ` Ray Jui
2015-09-17 23:58 ` [PATCH 2/4] ARM: dts: Enable various peripherals on bcm958305k Ray Jui
2015-09-17 23:58 ` Ray Jui
2015-09-17 23:58 ` Ray Jui
2015-09-17 23:58 ` [PATCH 3/4] ARM: dts: Enable NAND support on bcm911360_entphn Ray Jui
2015-09-17 23:58 ` Ray Jui
2015-09-17 23:58 ` Ray Jui
2015-09-17 23:58 ` [PATCH 4/4] ARM: dts: enable touchscreen support on Cygnus Ray Jui
2015-09-17 23:58 ` Ray Jui
2015-09-17 23:58 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FB66E4.8010006@broadcom.com \
--to=rjui@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.