All of lore.kernel.org
 help / color / mirror / Atom feed
From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: add wm9713 codec
Date: Fri, 18 Sep 2015 11:44:53 +0300	[thread overview]
Message-ID: <55FBCF05.2090707@compulab.co.il> (raw)
In-Reply-To: <1442432561-32722-1-git-send-email-robert.jarzmik@free.fr>

Hi Robert,

On 09/16/15 22:42, Robert Jarzmik wrote:
> The mioa701 is using the wm9713 for audio, battery and touchscreen. Add
> the missing audio part, which disappeared.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

The subject is a bit misleading..
I think it is worth specifying mioa701 in subject..

> ---
>  arch/arm/mach-pxa/mioa701.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
> index a7b392415a9e..d8e356d63471 100644
> --- a/arch/arm/mach-pxa/mioa701.c
> +++ b/arch/arm/mach-pxa/mioa701.c
> @@ -680,6 +680,7 @@ MIO_SIMPLE_DEV(mioa701_led,	  "leds-gpio",	    &gpio_led_info)
>  MIO_SIMPLE_DEV(pxa2xx_pcm,	  "pxa2xx-pcm",	    NULL)
>  MIO_SIMPLE_DEV(mioa701_sound,	  "mioa701-wm9713", NULL)
>  MIO_SIMPLE_DEV(mioa701_board,	  "mioa701-board",  NULL)
> +MIO_SIMPLE_DEV(wm9713_acodec,	  "wm9713-codec",   NULL);
>  MIO_SIMPLE_DEV(gpio_vbus,	  "gpio-vbus",      &gpio_vbus_data);
>  MIO_SIMPLE_DEV(mioa701_camera,	  "soc-camera-pdrv",&iclink);
>  
> @@ -687,6 +688,7 @@ static struct platform_device *devices[] __initdata = {
>  	&mioa701_gpio_keys,
>  	&mioa701_backlight,
>  	&mioa701_led,
> +	&wm9713_acodec,
>  	&pxa2xx_pcm,
>  	&mioa701_sound,
>  	&power_dev,
> 

-- 
Regards,
Igor.

WARNING: multiple messages have this Message-ID (diff)
From: Igor Grinberg <grinberg@compulab.co.il>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: pxa: add wm9713 codec
Date: Fri, 18 Sep 2015 11:44:53 +0300	[thread overview]
Message-ID: <55FBCF05.2090707@compulab.co.il> (raw)
In-Reply-To: <1442432561-32722-1-git-send-email-robert.jarzmik@free.fr>

Hi Robert,

On 09/16/15 22:42, Robert Jarzmik wrote:
> The mioa701 is using the wm9713 for audio, battery and touchscreen. Add
> the missing audio part, which disappeared.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

The subject is a bit misleading..
I think it is worth specifying mioa701 in subject..

> ---
>  arch/arm/mach-pxa/mioa701.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
> index a7b392415a9e..d8e356d63471 100644
> --- a/arch/arm/mach-pxa/mioa701.c
> +++ b/arch/arm/mach-pxa/mioa701.c
> @@ -680,6 +680,7 @@ MIO_SIMPLE_DEV(mioa701_led,	  "leds-gpio",	    &gpio_led_info)
>  MIO_SIMPLE_DEV(pxa2xx_pcm,	  "pxa2xx-pcm",	    NULL)
>  MIO_SIMPLE_DEV(mioa701_sound,	  "mioa701-wm9713", NULL)
>  MIO_SIMPLE_DEV(mioa701_board,	  "mioa701-board",  NULL)
> +MIO_SIMPLE_DEV(wm9713_acodec,	  "wm9713-codec",   NULL);
>  MIO_SIMPLE_DEV(gpio_vbus,	  "gpio-vbus",      &gpio_vbus_data);
>  MIO_SIMPLE_DEV(mioa701_camera,	  "soc-camera-pdrv",&iclink);
>  
> @@ -687,6 +688,7 @@ static struct platform_device *devices[] __initdata = {
>  	&mioa701_gpio_keys,
>  	&mioa701_backlight,
>  	&mioa701_led,
> +	&wm9713_acodec,
>  	&pxa2xx_pcm,
>  	&mioa701_sound,
>  	&power_dev,
> 

-- 
Regards,
Igor.

  reply	other threads:[~2015-09-18  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 19:42 [PATCH] ARM: pxa: add wm9713 codec Robert Jarzmik
2015-09-16 19:42 ` Robert Jarzmik
2015-09-18  8:44 ` Igor Grinberg [this message]
2015-09-18  8:44   ` Igor Grinberg
2015-09-18  9:38   ` Robert Jarzmik
2015-09-18  9:38     ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FBCF05.2090707@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.