From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h
Date: Fri, 18 Sep 2015 16:40:31 +0200 [thread overview]
Message-ID: <55FC225F.2080207@atmel.com> (raw)
In-Reply-To: <1439217979-15642-1-git-send-email-alexandre.belloni@free-electrons.com>
Le 10/08/2015 16:46, Alexandre Belloni a ?crit :
> struct at91_udc_data is now only used inside the driver, move it to its
> include.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/usb/gadget/udc/at91_udc.h | 8 ++++++++
> include/linux/platform_data/atmel.h | 9 ---------
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/at91_udc.h b/drivers/usb/gadget/udc/at91_udc.h
> index 2679c8b217cc..0a433e6b346b 100644
> --- a/drivers/usb/gadget/udc/at91_udc.h
> +++ b/drivers/usb/gadget/udc/at91_udc.h
> @@ -112,6 +112,14 @@ struct at91_udc_caps {
> void (*pullup)(struct at91_udc *udc, int is_on);
> };
>
> +struct at91_udc_data {
> + int vbus_pin; /* high == host powering us */
> + u8 vbus_active_low; /* vbus polarity */
> + u8 vbus_polled; /* Use polling, not interrupt */
> + int pullup_pin; /* active == D+ pulled up */
> + u8 pullup_active_low; /* true == pullup_pin is active low */
> +};
> +
> /*
> * driver is non-SMP, and just blocks IRQs whenever it needs
> * access protection for chip registers or driver state
> diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h
> index 4b452c6a2f7b..2d67e466c51b 100644
> --- a/include/linux/platform_data/atmel.h
> +++ b/include/linux/platform_data/atmel.h
> @@ -25,15 +25,6 @@
> */
> #define ATMEL_MAX_UART 7
>
> - /* USB Device */
> -struct at91_udc_data {
> - int vbus_pin; /* high == host powering us */
> - u8 vbus_active_low; /* vbus polarity */
> - u8 vbus_polled; /* Use polling, not interrupt */
> - int pullup_pin; /* active == D+ pulled up */
> - u8 pullup_active_low; /* true == pullup_pin is active low */
> -};
> -
> /* Compact Flash */
> struct at91_cf_data {
> int irq_pin; /* I/O IRQ */
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h
Date: Fri, 18 Sep 2015 16:40:31 +0200 [thread overview]
Message-ID: <55FC225F.2080207@atmel.com> (raw)
In-Reply-To: <1439217979-15642-1-git-send-email-alexandre.belloni@free-electrons.com>
Le 10/08/2015 16:46, Alexandre Belloni a écrit :
> struct at91_udc_data is now only used inside the driver, move it to its
> include.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks.
> ---
> drivers/usb/gadget/udc/at91_udc.h | 8 ++++++++
> include/linux/platform_data/atmel.h | 9 ---------
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/at91_udc.h b/drivers/usb/gadget/udc/at91_udc.h
> index 2679c8b217cc..0a433e6b346b 100644
> --- a/drivers/usb/gadget/udc/at91_udc.h
> +++ b/drivers/usb/gadget/udc/at91_udc.h
> @@ -112,6 +112,14 @@ struct at91_udc_caps {
> void (*pullup)(struct at91_udc *udc, int is_on);
> };
>
> +struct at91_udc_data {
> + int vbus_pin; /* high == host powering us */
> + u8 vbus_active_low; /* vbus polarity */
> + u8 vbus_polled; /* Use polling, not interrupt */
> + int pullup_pin; /* active == D+ pulled up */
> + u8 pullup_active_low; /* true == pullup_pin is active low */
> +};
> +
> /*
> * driver is non-SMP, and just blocks IRQs whenever it needs
> * access protection for chip registers or driver state
> diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h
> index 4b452c6a2f7b..2d67e466c51b 100644
> --- a/include/linux/platform_data/atmel.h
> +++ b/include/linux/platform_data/atmel.h
> @@ -25,15 +25,6 @@
> */
> #define ATMEL_MAX_UART 7
>
> - /* USB Device */
> -struct at91_udc_data {
> - int vbus_pin; /* high == host powering us */
> - u8 vbus_active_low; /* vbus polarity */
> - u8 vbus_polled; /* Use polling, not interrupt */
> - int pullup_pin; /* active == D+ pulled up */
> - u8 pullup_active_low; /* true == pullup_pin is active low */
> -};
> -
> /* Compact Flash */
> struct at91_cf_data {
> int irq_pin; /* I/O IRQ */
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-09-18 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:46 [PATCH] usb: gadget: at91_udc: move at91_udc_data in at91_udc.h Alexandre Belloni
2015-08-10 14:46 ` Alexandre Belloni
2015-09-18 14:40 ` Nicolas Ferre [this message]
2015-09-18 14:40 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC225F.2080207@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.