* Possible Bug in move_encrypted_block
@ 2015-09-19 17:36 nick
2015-09-21 18:51 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: nick @ 2015-09-19 17:36 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
Greetings Jaeguek and others.
Below are the lines fora possible bug in move_encrypted_block:
err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
if (err)
goto out;
Also calls of get_dnode_of_data need to hold the semaphone for the superblock
this call is being done on to avoid concurrent access on data being received
here from the superblock and file system on disk. In addition unless I get a
reply to this I will not be sending in a bug fix for this.
Nick
------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Possible Bug in move_encrypted_block
2015-09-19 17:36 Possible Bug in move_encrypted_block nick
@ 2015-09-21 18:51 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2015-09-21 18:51 UTC (permalink / raw)
To: nick; +Cc: linux-kernel, linux-f2fs-devel
Hi,
On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote:
> Greetings Jaeguek and others.
> Below are the lines fora possible bug in move_encrypted_block:
> err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
> if (err)
> goto out;
> Also calls of get_dnode_of_data need to hold the semaphone for the superblock
> this call is being done on to avoid concurrent access on data being received
IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this?
To be honest, I can't catch your point.
Thanks,
> here from the superblock and file system on disk. In addition unless I get a
> reply to this I will not be sending in a bug fix for this.
> Nick
------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Possible Bug in move_encrypted_block
@ 2015-09-21 18:51 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2015-09-21 18:51 UTC (permalink / raw)
To: nick; +Cc: cm224.lee, chao2.yu, linux-f2fs-devel, linux-kernel
Hi,
On Sat, Sep 19, 2015 at 01:36:08PM -0400, nick wrote:
> Greetings Jaeguek and others.
> Below are the lines fora possible bug in move_encrypted_block:
> err = get_dnode_of_data(&dn, bidx, LOOKUP_NODE);
> if (err)
> goto out;
> Also calls of get_dnode_of_data need to hold the semaphone for the superblock
> this call is being done on to avoid concurrent access on data being received
IIUC, the f2fs_lock_op() is not neeeded here. Do you mean this?
To be honest, I can't catch your point.
Thanks,
> here from the superblock and file system on disk. In addition unless I get a
> reply to this I will not be sending in a bug fix for this.
> Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-21 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-19 17:36 Possible Bug in move_encrypted_block nick
2015-09-21 18:51 ` Jaegeuk Kim
2015-09-21 18:51 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.