* [PATCH] drm/nouveau: remove unused function
@ 2015-09-02 6:38 ` Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-02 6:38 UTC (permalink / raw)
To: David Airlie, Daniel Vetter; +Cc: linux-kernel, dri-devel, Sudip Mukherjee
coverity.com reported that memset was using a buffer of size 0, on
checking the code it turned out that the function was not being used. So
remove it.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h | 2 --
drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c | 13 -------------
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
index d606875..3a643df 100644
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
@@ -4,8 +4,6 @@ struct nvbios_pmuT {
};
u32 nvbios_pmuTe(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len);
-u32 nvbios_pmuTp(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
- struct nvbios_pmuT *);
struct nvbios_pmuE {
u8 type;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
index 441ec45..c268e5a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
@@ -62,19 +62,6 @@ nvbios_pmuTe(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
}
u32
-nvbios_pmuTp(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
- struct nvbios_pmuT *info)
-{
- u32 data = nvbios_pmuTe(bios, ver, hdr, cnt, len);
- memset(info, 0x00, sizeof(*info));
- switch (!!data * *ver) {
- default:
- break;
- }
- return data;
-}
-
-u32
nvbios_pmuEe(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr)
{
u8 cnt, len;
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/nouveau: remove unused function
@ 2015-09-02 6:38 ` Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-02 6:38 UTC (permalink / raw)
To: David Airlie, Daniel Vetter; +Cc: linux-kernel, dri-devel, Sudip Mukherjee
coverity.com reported that memset was using a buffer of size 0, on
checking the code it turned out that the function was not being used. So
remove it.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h | 2 --
drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c | 13 -------------
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
index d606875..3a643df 100644
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/pmu.h
@@ -4,8 +4,6 @@ struct nvbios_pmuT {
};
u32 nvbios_pmuTe(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len);
-u32 nvbios_pmuTp(struct nvkm_bios *, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
- struct nvbios_pmuT *);
struct nvbios_pmuE {
u8 type;
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
index 441ec45..c268e5a 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c
@@ -62,19 +62,6 @@ nvbios_pmuTe(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len)
}
u32
-nvbios_pmuTp(struct nvkm_bios *bios, u8 *ver, u8 *hdr, u8 *cnt, u8 *len,
- struct nvbios_pmuT *info)
-{
- u32 data = nvbios_pmuTe(bios, ver, hdr, cnt, len);
- memset(info, 0x00, sizeof(*info));
- switch (!!data * *ver) {
- default:
- break;
- }
- return data;
-}
-
-u32
nvbios_pmuEe(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr)
{
u8 cnt, len;
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: remove unused function
2015-09-02 6:38 ` Sudip Mukherjee
@ 2015-09-15 7:45 ` Sudip Mukherjee
-1 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-15 7:45 UTC (permalink / raw)
To: David Airlie, Daniel Vetter; +Cc: linux-kernel, dri-devel
On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
A gentle ping.
regards
sudip
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: remove unused function
@ 2015-09-15 7:45 ` Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-15 7:45 UTC (permalink / raw)
To: David Airlie, Daniel Vetter; +Cc: linux-kernel, dri-devel
On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
A gentle ping.
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: remove unused function
2015-09-15 7:45 ` Sudip Mukherjee
(?)
@ 2015-09-21 12:57 ` Samuel Pitoiset
-1 siblings, 0 replies; 7+ messages in thread
From: Samuel Pitoiset @ 2015-09-21 12:57 UTC (permalink / raw)
To: dri-devel
On 09/15/2015 09:45 AM, Sudip Mukherjee wrote:
> On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
>> coverity.com reported that memset was using a buffer of size 0, on
>> checking the code it turned out that the function was not being used. So
>> remove it.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
> A gentle ping.
Good catch!
Thanks for reporting this, but the commit message should be something like:
"bios: remove unused nvbios_pmuTp() function"
The next time, don't forget to send patches to
nouveau@lists.freedesktop.org. ;)
This patch is:
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
>
> regards
> sudip
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: remove unused function
2015-09-02 6:38 ` Sudip Mukherjee
@ 2015-09-24 15:44 ` Sudip Mukherjee
-1 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-24 15:44 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Ben Skeggs; +Cc: linux-kernel, dri-devel
On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
Hi Ben,
A gentle ping.
regards
sudip
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/nouveau: remove unused function
@ 2015-09-24 15:44 ` Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2015-09-24 15:44 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Ben Skeggs; +Cc: linux-kernel, dri-devel
On Wed, Sep 02, 2015 at 12:08:08PM +0530, Sudip Mukherjee wrote:
> coverity.com reported that memset was using a buffer of size 0, on
> checking the code it turned out that the function was not being used. So
> remove it.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
Hi Ben,
A gentle ping.
regards
sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-24 15:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-02 6:38 [PATCH] drm/nouveau: remove unused function Sudip Mukherjee
2015-09-02 6:38 ` Sudip Mukherjee
2015-09-15 7:45 ` Sudip Mukherjee
2015-09-15 7:45 ` Sudip Mukherjee
2015-09-21 12:57 ` Samuel Pitoiset
2015-09-24 15:44 ` Sudip Mukherjee
2015-09-24 15:44 ` Sudip Mukherjee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.