From: Robin Murphy <robin.murphy@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4
Date: Tue, 15 Mar 2022 18:53:52 +0000 [thread overview]
Message-ID: <55a6f736-88c9-6be2-86cb-82fb8bd9f0ca@arm.com> (raw)
In-Reply-To: <1958426.K55CUjniD9@diego>
On 2022-03-15 18:43, Heiko Stübner wrote:
> Am Dienstag, 15. März 2022, 14:52:59 CET schrieb Robin Murphy:
>> The NanoPi4 boards have the RK808's always-on 32KHz clock wired to the
>> SoC, so have it claim the relevant pinctrl to actually enable the
>> CLK32K_IN input. The RK808's SLEEP pin is also wired to the SoC's
>> AP_PWROFF output, so we may as well claim that too.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> index 8c0ff6c96e03..cbb12cfd40be 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> @@ -267,7 +267,7 @@ rk808: pmic@1b {
>> interrupt-parent = <&gpio1>;
>> interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pmic_int_l>;
>> + pinctrl-0 = <&pmic_int_l>, <&ap_pwroff>, <&xin32k>;
>
> hmm that xin32k isn't present. Is this missing some previous patch?
Err... no, that should of course be &clk_32k :(
That's what happens when I leave ~24 hours between hacking about with
the board then typing up a proper patch from memory on a different
machine, then "git send-email @~1" without even build-testing because
it's so simple it can't possibly go wrong, right?
*Sigh* sorry for the noise, let me spin up a v2 and properly test it
this time...
Robin.
>
>> rockchip,system-power-controller;
>> wakeup-source;
>>
>>
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4
Date: Tue, 15 Mar 2022 18:53:52 +0000 [thread overview]
Message-ID: <55a6f736-88c9-6be2-86cb-82fb8bd9f0ca@arm.com> (raw)
In-Reply-To: <1958426.K55CUjniD9@diego>
On 2022-03-15 18:43, Heiko Stübner wrote:
> Am Dienstag, 15. März 2022, 14:52:59 CET schrieb Robin Murphy:
>> The NanoPi4 boards have the RK808's always-on 32KHz clock wired to the
>> SoC, so have it claim the relevant pinctrl to actually enable the
>> CLK32K_IN input. The RK808's SLEEP pin is also wired to the SoC's
>> AP_PWROFF output, so we may as well claim that too.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> index 8c0ff6c96e03..cbb12cfd40be 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
>> @@ -267,7 +267,7 @@ rk808: pmic@1b {
>> interrupt-parent = <&gpio1>;
>> interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
>> pinctrl-names = "default";
>> - pinctrl-0 = <&pmic_int_l>;
>> + pinctrl-0 = <&pmic_int_l>, <&ap_pwroff>, <&xin32k>;
>
> hmm that xin32k isn't present. Is this missing some previous patch?
Err... no, that should of course be &clk_32k :(
That's what happens when I leave ~24 hours between hacking about with
the board then typing up a proper patch from memory on a different
machine, then "git send-email @~1" without even build-testing because
it's so simple it can't possibly go wrong, right?
*Sigh* sorry for the noise, let me spin up a v2 and properly test it
this time...
Robin.
>
>> rockchip,system-power-controller;
>> wakeup-source;
>>
>>
>
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-15 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 13:52 [PATCH] arm64: dts: rockchip: Add some pins for NanoPi4 Robin Murphy
2022-03-15 13:52 ` Robin Murphy
2022-03-15 18:43 ` Heiko Stübner
2022-03-15 18:43 ` Heiko Stübner
2022-03-15 18:53 ` Robin Murphy [this message]
2022-03-15 18:53 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55a6f736-88c9-6be2-86cb-82fb8bd9f0ca@arm.com \
--to=robin.murphy@arm.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.