All of lore.kernel.org
 help / color / mirror / Atom feed
* + mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch added to -mm tree
@ 2015-08-31 20:31 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2015-08-31 20:31 UTC (permalink / raw)
  To: daniel, cl, iamjoonsoo.kim, penberg, rientjes, mm-commits


The patch titled
     Subject: mm/slab.h: fix argument order in cache_from_obj's error message
has been added to the -mm tree.  Its filename is
     mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Daniel Borkmann <daniel@iogearbox.net>
Subject: mm/slab.h: fix argument order in cache_from_obj's error message

While debugging a networking issue, I hit a condition that triggered an
object to be freed into the wrong kmem cache, and thus triggered the
warning in cache_from_obj().

The arguments in the error message are in wrong order: the location
of the object's kmem cache is in cachep, not s.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/slab.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN mm/slab.h~mm-slab-fix-argument-order-in-cache_from_objs-error-message mm/slab.h
--- a/mm/slab.h~mm-slab-fix-argument-order-in-cache_from_objs-error-message
+++ a/mm/slab.h
@@ -321,7 +321,7 @@ static inline struct kmem_cache *cache_f
 		return cachep;
 
 	pr_err("%s: Wrong slab cache. %s but object is from %s\n",
-	       __func__, cachep->name, s->name);
+	       __func__, s->name, cachep->name);
 	WARN_ON_ONCE(1);
 	return s;
 }
_

Patches currently in -mm which might be from daniel@iogearbox.net are

mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-31 20:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-31 20:31 + mm-slab-fix-argument-order-in-cache_from_objs-error-message.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.