All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] scripts-decode_stacktrace-fix-arm-architecture-decoding.patch removed from -mm tree
@ 2015-09-08 18:01 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2015-09-08 18:01 UTC (permalink / raw)
  To: robert.jarzmik, mmarek, rmk+kernel, sasha.levin, mm-commits


The patch titled
     Subject: scripts: decode_stacktrace: fix ARM architecture decoding
has been removed from the -mm tree.  Its filename was
     scripts-decode_stacktrace-fix-arm-architecture-decoding.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Robert Jarzmik <robert.jarzmik@free.fr>
Subject: scripts: decode_stacktrace: fix ARM architecture decoding

Fix the stack decoder for the ARM architecture.
An ARM stack is designed as :
[   81.547704] [<c023eb04>] (bucket_find_contain) from [<c023ec88>] (check_sync+0x40/0x4f8)
[   81.559668] [<c023ec88>] (check_sync) from [<c023f8c4>] (debug_dma_sync_sg_for_cpu+0x128/0x194)
[   81.571583] [<c023f8c4>] (debug_dma_sync_sg_for_cpu) from [<c0327dec>] (__videobuf_s

The current script doesn't expect the symbols to be bound by
parenthesis, and triggers the following errors :
awk: cmd. line:1: error: Unmatched ( or \(: / (check_sync$/
[   81.547704] (bucket_find_contain) from (check_sync+0x40/0x4f8)

Fix it by chopping starting and ending parenthesis from the each symbol
name.

As a side note, this probably comes from the function
dump_backtrace_entry(), which is implemented differently for each
architecture.  That makes a single decoding script a bit a challenge.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/decode_stacktrace.sh |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff -puN scripts/decode_stacktrace.sh~scripts-decode_stacktrace-fix-arm-architecture-decoding scripts/decode_stacktrace.sh
--- a/scripts/decode_stacktrace.sh~scripts-decode_stacktrace-fix-arm-architecture-decoding
+++ a/scripts/decode_stacktrace.sh
@@ -14,11 +14,14 @@ declare -A cache
 
 parse_symbol() {
 	# The structure of symbol at this point is:
-	#   [name]+[offset]/[total length]
+	#   ([name]+[offset]/[total length])
 	#
 	# For example:
 	#   do_basic_setup+0x9c/0xbf
 
+	# Remove the englobing parenthesis
+	symbol=${symbol#\(}
+	symbol=${symbol%\)}
 
 	# Strip the symbol name so that we could look it up
 	local name=${symbol%+*}
_

Patches currently in -mm which might be from robert.jarzmik@free.fr are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-08 18:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08 18:01 [merged] scripts-decode_stacktrace-fix-arm-architecture-decoding.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.