From: a.hajda@samsung.com (Andrzej Hajda)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero
Date: Mon, 21 Sep 2015 15:34:47 +0200 [thread overview]
Message-ID: <56000777.6060208@samsung.com> (raw)
In-Reply-To: <55FFFFF4.4000007@users.sourceforge.net>
On 09/21/2015 03:02 PM, SF Markus Elfring wrote:
>> v3: added bool type
> I would appreciate a bit more feedback for my concerns around your
> evolving approach.
Ups, I have missed your email.
> * Reuse of "long int"?
If you mean adding int to 'unsigned long [long]' types, it does not work.
For some reason it works only without adding int after long.
> * Splitting of the suggested SmPL rule so that each source code check
> will be connected with appropriate warning messages.
Personally I prefer one message as it is more compact and
fits quite well in both cases, but I have no strong fillings with separate
message for each case.
>
> Will any more fine-tuning be useful?
Could you elaborate it.
Regards
Andrzej
>
> Regards,
> Markus
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero
Date: Mon, 21 Sep 2015 13:34:47 +0000 [thread overview]
Message-ID: <56000777.6060208@samsung.com> (raw)
In-Reply-To: <55FFFFF4.4000007@users.sourceforge.net>
On 09/21/2015 03:02 PM, SF Markus Elfring wrote:
>> v3: added bool type
> I would appreciate a bit more feedback for my concerns around your
> evolving approach.
Ups, I have missed your email.
> * Reuse of "long int"?
If you mean adding int to 'unsigned long [long]' types, it does not work.
For some reason it works only without adding int after long.
> * Splitting of the suggested SmPL rule so that each source code check
> will be connected with appropriate warning messages.
Personally I prefer one message as it is more compact and
fits quite well in both cases, but I have no strong fillings with separate
message for each case.
>
> Will any more fine-tuning be useful?
Could you elaborate it.
Regards
Andrzej
>
> Regards,
> Markus
>
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Hajda <a.hajda@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Joe Perches <joe@perches.com>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
cocci@systeme.lip6.fr
Subject: Re: [PATCH v3] coccinelle: tests: unsigned value cannot be lesser than zero
Date: Mon, 21 Sep 2015 15:34:47 +0200 [thread overview]
Message-ID: <56000777.6060208@samsung.com> (raw)
In-Reply-To: <55FFFFF4.4000007@users.sourceforge.net>
On 09/21/2015 03:02 PM, SF Markus Elfring wrote:
>> v3: added bool type
> I would appreciate a bit more feedback for my concerns around your
> evolving approach.
Ups, I have missed your email.
> * Reuse of "long int"?
If you mean adding int to 'unsigned long [long]' types, it does not work.
For some reason it works only without adding int after long.
> * Splitting of the suggested SmPL rule so that each source code check
> will be connected with appropriate warning messages.
Personally I prefer one message as it is more compact and
fits quite well in both cases, but I have no strong fillings with separate
message for each case.
>
> Will any more fine-tuning be useful?
Could you elaborate it.
Regards
Andrzej
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2015-09-21 13:34 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:27 [Cocci] [PATCH] coccinelle: tests: unsigned value cannot be lesser than zero Andrzej Hajda
2015-09-15 9:27 ` Andrzej Hajda
2015-09-15 13:01 ` [Cocci] " SF Markus Elfring
2015-09-15 13:01 ` SF Markus Elfring
2015-09-15 13:01 ` SF Markus Elfring
2015-09-15 13:07 ` [Cocci] " Julia Lawall
2015-09-15 13:07 ` Julia Lawall
2015-09-15 13:07 ` Julia Lawall
2015-09-15 13:16 ` [Cocci] " SF Markus Elfring
2015-09-15 13:16 ` SF Markus Elfring
2015-09-15 13:16 ` SF Markus Elfring
2015-09-15 13:31 ` [Cocci] " Julia Lawall
2015-09-15 13:31 ` Julia Lawall
2015-09-15 13:31 ` Julia Lawall
2015-09-15 13:51 ` [Cocci] " Andrzej Hajda
2015-09-15 13:51 ` Andrzej Hajda
2015-09-15 13:51 ` Andrzej Hajda
2015-09-15 13:57 ` [Cocci] " Julia Lawall
2015-09-15 13:57 ` Julia Lawall
2015-09-15 13:57 ` Julia Lawall
2015-09-16 9:11 ` [Cocci] " Andrzej Hajda
2015-09-16 9:11 ` Andrzej Hajda
2015-09-16 9:11 ` Andrzej Hajda
2015-09-16 9:25 ` [Cocci] " Julia Lawall
2015-09-16 9:25 ` Julia Lawall
2015-09-16 9:25 ` Julia Lawall
2015-09-16 13:22 ` [Cocci] [PATCH v2] " Andrzej Hajda
2015-09-16 13:22 ` Andrzej Hajda
2015-09-16 13:33 ` [Cocci] " Julia Lawall
2015-09-16 13:33 ` Julia Lawall
2015-09-16 18:56 ` [Cocci] " SF Markus Elfring
2015-09-16 18:56 ` SF Markus Elfring
2015-09-16 18:56 ` SF Markus Elfring
2015-09-15 13:42 ` [Cocci] [PATCH] " Andrzej Hajda
2015-09-15 13:42 ` Andrzej Hajda
2015-09-15 13:42 ` Andrzej Hajda
2015-09-15 14:36 ` [Cocci] " SF Markus Elfring
2015-09-15 14:36 ` SF Markus Elfring
2015-09-15 14:36 ` SF Markus Elfring
2015-09-15 14:43 ` [Cocci] " Julia Lawall
2015-09-15 14:43 ` Julia Lawall
2015-09-15 14:43 ` Julia Lawall
2015-09-15 14:53 ` SF Markus Elfring
2015-09-15 14:53 ` SF Markus Elfring
2015-09-15 14:53 ` SF Markus Elfring
2015-09-18 5:35 ` Julia Lawall
2015-09-18 5:35 ` Julia Lawall
2015-09-18 5:35 ` Julia Lawall
2015-09-21 10:37 ` [Cocci] [PATCH v3] " Andrzej Hajda
2015-09-21 10:37 ` Andrzej Hajda
2015-09-21 10:37 ` Andrzej Hajda
2015-09-21 13:02 ` [Cocci] " SF Markus Elfring
2015-09-21 13:02 ` SF Markus Elfring
2015-09-21 13:02 ` SF Markus Elfring
2015-09-21 13:34 ` Andrzej Hajda [this message]
2015-09-21 13:34 ` Andrzej Hajda
2015-09-21 13:34 ` Andrzej Hajda
2015-09-21 14:06 ` [Cocci] " SF Markus Elfring
2015-09-21 14:06 ` SF Markus Elfring
2015-09-21 14:06 ` SF Markus Elfring
2015-09-22 15:27 ` [Cocci] " SF Markus Elfring
2015-09-22 15:27 ` SF Markus Elfring
2015-09-22 15:27 ` SF Markus Elfring
2015-09-23 7:34 ` [Cocci] " Andrzej Hajda
2015-09-23 7:34 ` Andrzej Hajda
2015-09-23 7:34 ` Andrzej Hajda
2015-09-23 15:17 ` [Cocci] " SF Markus Elfring
2015-09-23 15:17 ` SF Markus Elfring
2015-09-23 15:17 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56000777.6060208@samsung.com \
--to=a.hajda@samsung.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.