From: Murali Karicheri <m-karicheri2@ti.com>
To: <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>
Cc: "rmk+kernel@arm.linux.org.uk >> Russell King"
<rmk+kernel@arm.linux.org.uk>
Subject: request to merge commit 3302caddf10ad50710dbb7a94ccbdb3ad5bf1412
Date: Mon, 21 Sep 2015 18:13:01 -0400 [thread overview]
Message-ID: <560080ED.6090607@ti.com> (raw)
Hi Maintainer,
The below commit fixes the Warning shown in the trace below when debug
options are enabled in the kernel build. Could you please merge this to
address the issue for v4.1.9?
Thanks
============================================================================
commit 3302caddf10ad50710dbb7a94ccbdb3ad5bf1412
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date: Thu Aug 20 16:13:37 2015 +0100
ARM: entry: efficiency cleanups
Make the "fast" syscall return path fast again. The addition of IRQ
tracing and context tracking has made this path grossly inefficient.
We can do much better if these options are enabled if we save the
syscall return code on the stack - we then don't need to save a bunch
of registers around every single callout to C code.
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
================================================================================
Warning log below which is addressed by above commit.
[ 17.401337] ------------[ cut here ]------------
[ 17.405991] WARNING: CPU: 2 PID: 1201 at
kernel/locking/lockdep.c:3557 check_flags.part.37+0x224/0x228()
[ 17.415508] DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)
[ 17.420836] Modules linked in:
[ 17.424087] CPU: 2 PID: 1201 Comm: udevd Tainted: G W
4.1.6-01270-gcdac6fd #1
[ 17.432379] Hardware name: Keystone
[ 17.435894] [<c00178e4>] (unwind_backtrace) from [<c0013cbc>]
(show_stack+0x10/0x14)
[ 17.443673] [<c0013cbc>] (show_stack) from [<c05ff398>]
(dump_stack+0x84/0xc4)
[ 17.450926] [<c05ff398>] (dump_stack) from [<c0028990>]
(warn_slowpath_common+0x84/0xb4)
[ 17.459048] [<c0028990>] (warn_slowpath_common) from [<c00289f0>]
(warn_slowpath_fmt+0x30/0x40)
[ 17.467781] [<c00289f0>] (warn_slowpath_fmt) from [<c006c37c>]
(check_flags.part.37+0x224/0x228)
[ 17.476601] [<c006c37c>] (check_flags.part.37) from [<c006ce48>]
(lock_is_held+0x88/0x94)
[ 17.484811] [<c006ce48>] (lock_is_held) from [<c008eb9c>]
(rcu_note_context_switch+0x854/0x8c0)
[ 17.493545] [<c008eb9c>] (rcu_note_context_switch) from [<c0600b54>]
(__schedule+0x40/0x844)
[ 17.502017] [<c0600b54>] (__schedule) from [<c0601398>]
(schedule+0x40/0x98)
[ 17.509097] [<c0601398>] (schedule) from [<c001364c>]
(do_work_pending+0x24/0xb0)
[ 17.516610] [<c001364c>] (do_work_pending) from [<c000ffc4>]
(work_pending+0xc/0x20)
[ 17.524380] ---[ end trace fe0042166f5d3227 ]---
[ 17.529009] possible reason: unannotated irqs-off.
[ 17.533813] irq event stamp: 331979
[ 17.537308] hardirqs last enabled at (331979): [<c000fffc>]
no_work_pending+0x8/0x30
[ 17.545172] hardirqs last disabled at (331978): [<c000ffe4>]
ret_slow_syscall+0xc/0x10
[ 17.553123] softirqs last enabled at (327182): [<c002ca90>]
__do_softirq+0x4dc/0x6cc
[ 17.560987] softirqs last disabled at (327177): [<c002cf88>]
irq_exit+0x98/0xcc
--
Murali Karicheri
Linux Kernel, Keystone
next reply other threads:[~2015-09-21 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 22:13 Murali Karicheri [this message]
2015-10-17 21:32 ` request to merge commit 3302caddf10ad50710dbb7a94ccbdb3ad5bf1412 Greg KH
2015-10-17 22:40 ` Russell King - ARM Linux
2015-10-19 14:15 ` Murali Karicheri
2015-10-19 16:19 ` Murali Karicheri
2015-10-19 17:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560080ED.6090607@ti.com \
--to=m-karicheri2@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.